added missed "options" argument for AwsAdapterDefinitionBuilder

[psolom]

League\Flysystem\AwsS3v3\AwsS3Adapter supports 4th argument named "options", but it's missed in this package.

With the proposed changes I can now describe AWS storage as the following:

flysystem:
    storages:
        aws.storage:
            adapter: 'aws'
            options:
                client: 'aws-client-id'
                bucket: 'bucket-name'
                options:
                    ACL: 'public-read'

You can see the ACL: 'public-read' which is now passed to AwsS3Adapter

Please release new version after merge.

[tgalopin]

Hello @servocoder !

Thanks for your PR! Could you rebase on master (to avoid having a duplicated commit in the PR) and add the option in tests (don't hesitate to use #12 as an example :) ).

[psolom]

Rebase is not the thing I'm experienced a lot with. Perhaps it would be better if you close my PR and commit the changes at your own.

[tgalopin]

Ah, I understand! We can do it two ways then:

• I can give you a hand to finish this yourself (and it'll help you do it in the future too ;) ): if so, let's discuss on Symfony Slack (symfony.com/support)
• Or I can update this PR in order to fix things, if you don't have time to finalize all this :)

[psolom]

Go with option 2 please - complete it for me
I'm really a lack of time to rework this PR properly
And thanks for your suggestion of assistance, appreciate it!

[psolom]

Hey @tgalopin, any chance to get it done soon?

[psolom]

gentle reminder

[tgalopin]

Hello @servocoder!

Thanks for the reminder :) . Unfortunately, I'm very busy this summer and I try to focus my open-source work to what's needed for maintenance and stability. When I'll have time, I'll work on new features such as this one :) .

If someone else wants to create a PR on this, feel free to do so!

EDIT: "closed" misclick

[nico-incubiq]

@tgalopin @servocoder I opened #22 which is based on latest master and has added test coverage for the new options. hope it helps

[tgalopin]

Fixed by #22

[tgalopin]

Thanks @servocoder for the original PR and @nico-incubiq for having finished it. OSS is powerful :) .

[psolom]

Great! Thanks @nico-incubiq
@tgalopin Looking forward a new package release

[tgalopin]

I'm waiting a few days to see if #19 can be merged but I'll release a new tag yes :) .

[tgalopin]

Released: https://github.com/thephpleague/flysystem-bundle/releases/tag/1.2.0 !

[psolom]

Thanks!