Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing permission options for sftp adapter #19

Merged
merged 5 commits into from
Aug 27, 2019
Merged

Add missing permission options for sftp adapter #19

merged 5 commits into from
Aug 27, 2019

Conversation

meranote
Copy link
Contributor

Fixes #17

Add directoryPerm, permPrivate and permPublic to configurable (for directory/file permission), also add to the sftp document

tgalopin
tgalopin reviewed Aug 21, 2019
View reviewed changes
Copy link
Member

@tgalopin tgalopin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @chaniwat !

It seems there are few things to fix in your PR before I can merge it. Do you have a few minutes to have a look :) ?

@tgalopin tgalopin mentioned this pull request Aug 21, 2019
Closed
@meranote
Copy link
Contributor Author

@tgalopin done :)

@tgalopin
Copy link
Member

Thanks @chaniwat :) !

@tgalopin tgalopin merged commit f68baf6 into thephpleague:master Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgalopin tgalopin tgalopin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot set "directoryPerm" option on sftp adapter
2 participants
@meranote @tgalopin