Fixed only_process option with proc #2289
Conversation
Bug introduced in 1c7d7f6
| @@ -240,7 +240,8 @@ def dirty? | |||
| # the instance's errors and returns false, cancelling the save. | |||
| def save | |||
| flush_deletes unless @options[:keep_old_files] | |||
| if @options[:only_process].any? && !@options[:only_process].include?(:original) | |||
| process = only_process | |||
There was a problem hiding this comment.
Maybe it would be better to memoize only_process method?
If it's called somewhere else, proc will be computed again. What do you think?
There was a problem hiding this comment.
Maybe it would be better to memoize only_process method?
If it's called somewhere else, proc will be computed again. What do you think?
Could that present regressions? For now, I'd rather not cache it, and wait for it to actually become a bottleneck to discuss if we should go down that road. Thanks!
|
Thanks so much! 🎉 |
Bug introduced in 1c7d7f6 Per 1c7d7f6#commitcomment-18765681 request
|
Regardless of the contents of only_process, shouldn't the original file always be written to the file system? I recently raised an issue when using the latest version of Paperclip with Delayed Paperclip - jrgifford/delayed_paperclip#199 |
Bug introduced in 1c7d7f6
Per 1c7d7f6#commitcomment-18765681 request /cc @tute