-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix #643] fix retry with resolvedlocks info #645
Conversation
Signed-off-by: ajian2002 <[email protected]>
bc2488a
to
b516cb9
Compare
Codecov ReportBase: 34.81% // Head: 35.30% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #645 +/- ##
============================================
+ Coverage 34.81% 35.30% +0.49%
- Complexity 1433 1460 +27
============================================
Files 278 278
Lines 17377 17449 +72
Branches 1974 1988 +14
============================================
+ Hits 6049 6160 +111
+ Misses 10715 10669 -46
- Partials 613 620 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: ajian2002 <[email protected]>
/run-all-tests |
Is this modification necessary to increase testing? @iosmanthus |
8dc085f
to
5791041
Compare
This PR is stale because it has been open 30 days with no activity. Remove the status/stale label or comment or this PR will be closed in 7 days. |
This PR was closed because it has been stalled for 7 days with no activity. |
closed by duplicating with #685 |
What problem does this PR solve?
Issue Number: close #643
Problem Description:
The lock information that is being cleaned up will be cached in the RegionStoreClient so that it can be used to unlock the next time it is retried. Failure to cache this information will cause the unlock to fail until the lock is cleaned up until it times out or the lock is cleaned up.
What is changed and how does it work?
Like this pullrequest pingcap/tispark#1907, cache the lock information and try again to avoid creating a new client that does not hold the lock information to retry.
Check List for Tests