Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix #643] fix retry with resolvedlocks info #645

Closed
wants to merge 2 commits into from

Conversation

yegetables
Copy link

What problem does this PR solve?

Issue Number: close #643

Problem Description:

The lock information that is being cleaned up will be cached in the RegionStoreClient so that it can be used to unlock the next time it is retried. Failure to cache this information will cause the unlock to fail until the lock is cleaned up until it times out or the lock is cleaned up.

What is changed and how does it work?

Like this pullrequest pingcap/tispark#1907, cache the lock information and try again to avoid creating a new client that does not hold the lock information to retry.

Check List for Tests

  • Unit test
  • Integration test

@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Base: 34.81% // Head: 35.30% // Increases project coverage by +0.49% 🎉

Coverage data is based on head (5791041) compared to base (1b5edcd).
Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #645      +/-   ##
============================================
+ Coverage     34.81%   35.30%   +0.49%     
- Complexity     1433     1460      +27     
============================================
  Files           278      278              
  Lines         17377    17449      +72     
  Branches       1974     1988      +14     
============================================
+ Hits           6049     6160     +111     
+ Misses        10715    10669      -46     
- Partials        613      620       +7     
Impacted Files Coverage Δ
...java/org/tikv/common/region/RegionStoreClient.java 52.41% <33.33%> (-0.08%) ⬇️
...ty/handler/codec/http2/Http2ConnectionHandler.java 47.92% <0.00%> (-0.25%) ⬇️
src/main/java/io/grpc/stub/ClientCalls.java 48.51% <0.00%> (+2.31%) ⬆️
src/main/java/org/tikv/common/region/TiRegion.java 73.50% <0.00%> (+4.27%) ⬆️
...rc/main/java/io/grpc/netty/NettyClientHandler.java 63.36% <0.00%> (+6.46%) ⬆️
...ain/java/org/tikv/common/region/RegionManager.java 80.99% <0.00%> (+6.99%) ⬆️
.../main/java/org/tikv/common/region/TiStoreType.java 83.33% <0.00%> (+16.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yegetables
Copy link
Author

/run-all-tests

@yegetables
Copy link
Author

Is this modification necessary to increase testing? @iosmanthus

@github-actions
Copy link

This PR is stale because it has been open 30 days with no activity. Remove the status/stale label or comment or this PR will be closed in 7 days.

@github-actions
Copy link

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this Sep 18, 2022
@zhangyangyu zhangyangyu reopened this Dec 16, 2022
@shiyuhang0
Copy link
Collaborator

closed by duplicating with #685

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In client-java, is there a retry mechanism for batchGet Retry?
4 participants