-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[close #684] Fix batch get blocked by write #685
Conversation
Codecov ReportBase: 35.01% // Head: 36.86% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #685 +/- ##
============================================
+ Coverage 35.01% 36.86% +1.84%
- Complexity 1446 1537 +91
============================================
Files 278 278
Lines 17382 17386 +4
Branches 1975 1976 +1
============================================
+ Hits 6086 6409 +323
+ Misses 10681 10322 -359
- Partials 615 655 +40
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
85133ab
to
e538114
Compare
Signed-off-by: shiyuhang <[email protected]>
Signed-off-by: shiyuhang <[email protected]>
Signed-off-by: shiyuhang <[email protected]>
Signed-off-by: shiyuhang <[email protected]>
Signed-off-by: shiyuhang <[email protected]>
Signed-off-by: shiyuhang <[email protected]>
Signed-off-by: zhangyangyu <[email protected]> Signed-off-by: shiyuhang <[email protected]>
498f056
to
2f897b3
Compare
@zhangyangyu, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. You are not a reviewer or committer or co-leader or leader. |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-3.3 in PR #691 |
Signed-off-by: shiyuhang <[email protected]>
Signed-off-by: shiyuhang <[email protected]> Signed-off-by: iosmanthus <[email protected]>
Signed-off-by: shiyuhang [email protected]
What problem does this PR solve?
Issue Number: close #684
Problem Description: TBD
What is changed and how does it work?
Client-java's batchGet should retry to request TiKV with the ResolvedLocks context. So that the requests can ignore locks belonging to other transactions, because their commit_ts > read request's start_ts after pushing min_commit_ts in the first batchGet,
Just add ResolvedLocks filed in KVClient to cache the information and used it in the retry.
Code changes
Check List for Tests
This PR has been tested by at least one of the following methods:
Side effects
Related changes