-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unit-test CI #172
Comments
This problem occurred when we added the borrowed-from-Ruler tests
As an interim measure I guess I can just put the |
fixes: #172 Signed-off-by: Tim Bray <[email protected]>
Yay, #173 seems to fix this. Now, it does mean that two quite useful unit tests are not being run. We should probably update the instructions in CONTRIBUTING.md to say "please run unit tests with Since the unit-test coverage is still excellent without these tests, I think I'd like to go ahead and merge this, and then file a new issue to figure out how to get these back into the CI. |
This is OK with me. We could create a second workflow only running specific go tests (since we can't easily exclude those without build tags). Gets a bit tricky if we change the tests in |
Currently the GitHub task that runs the unit tests fails with the message mentioning "error code 143". This turns out to be an acknowledged problem in GitHub, see actions/runner-images#6680 (comment)
The unit tests pass reliably on "normal" computers.
Perhaps restructuring the GitHub tasks and using Go build tags will address this problem.
The text was updated successfully, but these errors were encountered: