Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit-test CI #172

Closed
timbray opened this issue Jan 17, 2023 · 3 comments · Fixed by #173
Closed

Fix unit-test CI #172

timbray opened this issue Jan 17, 2023 · 3 comments · Fixed by #173

Comments

@timbray
Copy link
Owner

timbray commented Jan 17, 2023

Currently the GitHub task that runs the unit tests fails with the message mentioning "error code 143". This turns out to be an acknowledged problem in GitHub, see actions/runner-images#6680 (comment)

The unit tests pass reliably on "normal" computers.

Perhaps restructuring the GitHub tasks and using Go build tags will address this problem.

@timbray
Copy link
Owner Author

timbray commented Jan 17, 2023

This problem occurred when we added the borrowed-from-Ruler tests cl2_test.go and generic_machine_test.go. So the hypothesis is that these tests pushed the GitHub infrastructure into overload. I can see two ways that this could be addressed:

  • put those tests in a different package - would want to talk about how to structure folders and so on
  • put a build tag //go:build fromRuler on those tests, and //go:build !fromRuler on all the others, then have two different GitHub tasks workflows, one with -tags=fromRuler and one without.

As an interim measure I guess I can just put the fromRuler tag on the two files and make a little PR to see whether the in the PR validation, the unit-test step actually passes. I'll do that.

@timbray
Copy link
Owner Author

timbray commented Jan 17, 2023

Yay, #173 seems to fix this. Now, it does mean that two quite useful unit tests are not being run. We should probably update the instructions in CONTRIBUTING.md to say "please run unit tests with -tags=fromRuler".

Since the unit-test coverage is still excellent without these tests, I think I'd like to go ahead and merge this, and then file a new issue to figure out how to get these back into the CI.

@embano1
Copy link
Collaborator

embano1 commented Jan 18, 2023

This is OK with me. We could create a second workflow only running specific go tests (since we can't easily exclude those without build tags). Gets a bit tricky if we change the tests in fromRuler, but better than not running them at all IMHO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants