Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: exclude ruler-sourced tests from unit test build #173

Merged
merged 1 commit into from
Jan 19, 2023
Merged

fix: exclude ruler-sourced tests from unit test build #173

merged 1 commit into from
Jan 19, 2023

Conversation

timbray
Copy link
Owner

@timbray timbray commented Jan 17, 2023

fixes: #172
Signed-off-by: Tim Bray [email protected]

The object of the game is to workaround GitHub issues.

@timbray timbray requested a review from embano1 January 17, 2023 17:50
@timbray timbray mentioned this pull request Jan 17, 2023
Closed
embano1
embano1 approved these changes Jan 18, 2023
View reviewed changes
Copy link
Collaborator

@embano1 embano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merging this will close the issue so just make sure we have a tracking issue how to handle the missing unit tests going forward.

@timbray timbray merged commit 34f9dcc into main Jan 19, 2023
@timbray timbray deleted the issue-172 branch January 20, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embano1 embano1 embano1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix unit-test CI
2 participants
@timbray @embano1