Skip to content

Commit

Permalink
Continue supporting windows 7 with builds
Browse files Browse the repository at this point in the history
By using an older version of rust to build the artifacts on windows.

Alternatively we could build separate artifacts for windows 7, and
continue using the latest version of rust for later versions of windows
that are more optimized for more recent versions.

Fixes: sharkdp#1550
  • Loading branch information
tmccombs committed Jun 14, 2024
1 parent af61fe8 commit 38677bc
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/CICD.yml
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,9 @@ jobs:
uses: dtolnay/rust-toolchain@stable
with:
targets: ${{ matrix.job.target }}
# On windows, for now build with 1.77.2, so that it works on windows 7.
# When we update the MSRV again, we'll need to revisit this, and probably drop support for Win7
toolchain: "${{ contains(matrix.job.target, 'windows-') && '1.77.2' || 'stable' }}"

- name: Install cross
if: matrix.job.use-cross
Expand Down

0 comments on commit 38677bc

Please sign in to comment.