deps: require curl < 0.4.34 to fix MSRV
#382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds are failing on unrelated pull requests (e.g., tokio-rs#326) because the `curl` crate has pushed a new version that depends on Rust 1.40, while our CI tests against 1.39. We could probably bump to require 1.40 as well, especially since we want to use the same `#[non_exhaustive]` attribute, per tokio-rs#43. But a minimal change to unblock development and keep the current minimum stable Rust version is to just pin `curl < 0.4.34`. Test Plan: Running `cargo +1.39.0 test --workspace --all-targets` passes on my Linux machine. wchargin-branch: deps-curl-pre-0.4.34 wchargin-source: c2910530bd49190605176c9f69f3aff1863443c2
This was referenced Nov 7, 2020
Closed
|
Thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds are failing on unrelated pull requests (e.g., #326) because the
curlcrate has pushed a new version that depends on Rust 1.40, whileour CI tests against 1.39. We could probably bump to require 1.40 as
well, especially since we want to use the same
#[non_exhaustive]attribute, per #43. But a minimal change to unblock development and keep
the current minimum stable Rust version is to just pin
curl < 0.4.34.Test Plan:
Running
cargo +1.39.0 test --workspace --all-targetspasses on myLinux machine.
wchargin-branch: deps-curl-pre-0.4.34