tokio-process: change CommandExt to a fully asynchronous Command struct #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipetkov
approved these changes
Aug 16, 2019
There was a problem hiding this comment.
Awesome work @Kobzol, looks great!
Happy to merge this in once the CI is squared away.
Feel free to ping me if you need help wording anything around the docs (though I imagine we can largely adapt what the std docs say and that should be enough)
ipetkov
reviewed
Aug 17, 2019
ipetkov
approved these changes
Aug 17, 2019
|
I applied the suggestions, squashed the commits and rebased onto master. |
|
Seems the CI is failing now, looks like the imports need a quick tweak? |
|
Thanks, I screwed up solving a merge conflict while rebasing onto master. |
|
CI was failing due to missing the fix added in #1464 I figured out how to update the branch after rebasing again on the latest master, let's see if this fixes the CI |
|
CI is green, going to merge this in, thanks again @Kobzol! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1371 suggested to rewrite
CommandExtin a way similar totokio-fs(wrap thestdstruct and expose only asynchronous functions). I started rewriting Command in such a way.Documentation and doctests are not updated yet, I just transformed the minimum amount of code to make tests pass. Please let me know if it's OK and if I shall continue :)
Refs: #1371