sync: fix fuzz_oneshot test by using instrumented loom::sync::Arc
#1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phlip9
changed the title
loom::sync::Arcloom::sync::Arc
Since `tokio_sync::oneshot` makes a `CausalCell::with_mut()` mutable access in the `Inner::drop()`, we must use the instrumented `loom::sync::Arc`. Uncovered by tokio-rs/loom#42
phlip9
force-pushed
the
fix_oneshot_fuzz
branch
from
82a41fb to
17e1789
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
tokio_sync::oneshotmakes aCausalCell::with_mut()mutableaccess in the
Inner::drop(), we must use the instrumentedloom::sync::Arc.To be clear, there is no issue with the underlying
tokio_sync::oneshot.This change just fixes the test so that it no longer reports a false negative
test output.
Uncovered by tokio-rs/loom#42