Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix input group btn z index #170

Merged
merged 3 commits into from
May 17, 2018
Merged

Conversation

taaviaasver
Copy link

  • Remove a rule that set .input-group-btn > .btn/.btn-group z-index to 2. It caused an issue with MoneyInput - dropdown was not always on top (see image below). The rule should be safe to remove, because orginal fix (input-group btn border overlap when hovered twbs/bootstrap#15944) doesn't seem to be applicable - input element inside an .input-group with a button on the right side does not have border on the right side.
  • Increase quint timeout (5s default to 10s) to reduce occasional timeouts
  • Update grunt-contrib-quint (tests/PhantomJS didn't run with older version, macOs High Sierra 10.13.4)
  • Update readme about jekyll (maybe it will help other new contributors a bit) and update gems

z-bug

@taaviaasver taaviaasver merged commit 0a7e12f into master May 17, 2018
@taaviaasver taaviaasver deleted the fix-input-group-btn-z-index branch May 17, 2018 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants