Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input-group btn border overlap when hovered #15944

Closed
oalexdoda opened this issue Feb 27, 2015 · 4 comments · Fixed by #15945
Closed

input-group btn border overlap when hovered #15944

oalexdoda opened this issue Feb 27, 2015 · 4 comments · Fixed by #15945
Labels

Comments

@oalexdoda
Copy link

The
.input-group-btn:last-child>.btn, .input-group-btn:last-child>.btn-group
property should have z-index:2 to prevent a border overlapping issue on input-group when hovering.

Here is a demo video:
https://www.dropbox.com/s/wq13tw1ttz9oah4/bootstrap_bug.mov?dl=0

kkirsche added a commit to kkirsche/bootstrap that referenced this issue Feb 27, 2015
[Fixes twbs#15944] Add Z-Index to avoid border overlapping
@nextgenthemes
Copy link
Contributor

Nice but I am wondering if a z-index 2 (or any value for that matter) will not open up more problems when using this elements inside other z-indexed elements like modals and where bootstrap uses height z-indexes of 1000+ or just some custom z-indexed elements users may use.

@oalexdoda
Copy link
Author

Good point! Maybe assigning a z-index value higher than the top possible component helps. Or maybe the input inside the group should not have a border-right and the button should not have negative margin? There are many approaches to fix this :)

@cvrebert cvrebert added the css label Feb 27, 2015
@cvrebert cvrebert changed the title Field-Button Group Issue input-group btn border overlap when hovered Feb 27, 2015
@mdo mdo closed this as completed in #15945 Apr 5, 2015
mdo added a commit that referenced this issue Apr 5, 2015
[Fixes #15944] Add Z-Index to avoid border overlapping
@matthiaz
Copy link

Nice but I am wondering if a z-index 2 (or any value for that matter) will not open up more problems when using this elements inside other z-indexed elements like modals and where bootstrap uses height z-indexes of 1000+ or just some custom z-indexed elements users may use.

@alexandrudoda yeah... I have an input-group on a modal popup and I was receiving a very strange issue. On focus I can't type anything in the field.

I fixed this by adding z-index: 9000 but it might be a good idea to reopen this issue and raise the z-index.

@trevorr
Copy link

trevorr commented Jun 21, 2016

I've just noticed this change causes the focus outline of inner buttons to be covered:

screen shot 2016-06-21 at 6 21 40 pm

Removing it results in the desired appearance:

screen shot 2016-06-21 at 6 22 29 pm

I don't understand this issue, since the demo video link is now broken, but why does the fix only apply to .input-group-btn:last-child and not the analogous .input-group-btn:first-child? Perhaps active/focused buttons should get z-index: 3, similar to .form-control:focus?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants