Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the defaults to forward the headers #194

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Set the defaults to forward the headers #194

merged 2 commits into from
Jan 31, 2024

Conversation

vishalya
Copy link
Member

This is should be default value, dropwizard changed the defaults from 1.0 to some higher version. It takes care of the issues like #114

@cla-bot cla-bot bot added the cla-signed label Jan 26, 2024
willmostly
willmostly approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@willmostly willmostly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I would love to see some e2e tests including oauth on the backends to give us a better chance to catch changes in defaults, but I don't think it is possible with our current test framework. I'll open an issue for that.

@mosabua
Copy link
Member

mosabua commented Jan 26, 2024

Can you add it to the docker config file as well ... then I am good with it.

Chaho12
Chaho12 approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@Chaho12 Chaho12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for quick fix. LGTM 👍

@Chaho12 Chaho12 mentioned this pull request Jan 30, 2024
Closed
@vishalya vishalya changed the title set the defaults to forward the headers Set the defaults to forward the headers Jan 31, 2024
mosabua
mosabua approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vishalya

@mosabua mosabua merged commit 98a2372 into trinodb:main Jan 31, 2024
2 checks passed
@mosabua
Copy link
Member

mosabua commented Jan 31, 2024

Squashed, reworded commit message, and merged.

@github-actions github-actions bot added this to the 6 milestone Jan 31, 2024
@mosabua mosabua mentioned this pull request Feb 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebyhr ebyhr ebyhr left review comments

@mosabua mosabua mosabua approved these changes

@willmostly willmostly willmostly approved these changes

@Chaho12 Chaho12 Chaho12 approved these changes

Assignees
No one assigned
Labels
cla-signed
Milestone
6
Development

Successfully merging this pull request may close these issues.
5 participants
@vishalya @mosabua @ebyhr @willmostly @Chaho12