Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation update #217

Closed
wants to merge 2 commits into from
Closed

Documentation update #217

wants to merge 2 commits into from

Conversation

ruschecker
Copy link

This config required to let trino know that request has been proxied from gateway.

Copy link

cla-bot bot commented Jan 30, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Copy link
Member

@Chaho12 Chaho12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk if this will be necessary as it will be added by default.
@vishalya what do you think?

@mosabua
Copy link
Member

mosabua commented Jan 30, 2024

The Trino Gateway configuration is separate from the Trino configuration.. we might need both. This PR would have to move the changes into a section that talks about the Trino cluster configuration.

And @vishalya is still updating his PR to add the same config to the docker example config and then we will merge that PR separately.

@mosabua
Copy link
Member

mosabua commented Apr 3, 2024

👋 @ruschecker .. are you going to update this PR or should I send a replacement addressing the concerns raised in the review.

@mosabua
Copy link
Member

mosabua commented Apr 3, 2024

Replaced by #297 as agreed in the dev sync meeting.

@mosabua mosabua closed this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants