Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move @storybook/addons to peerDependencies #15

Merged

Conversation

matteocng
Copy link
Contributor

Moves @storybook/addons to peerDependencies and alerts the user in the README, should help with Accessing nonexistent addons channel errors if the user also installs it as a dependency in the main app.

This modification has been applied to all official storybook addons: storybookjs/storybook#2335 and released in versions: 3.3.0-alpha*

Also see #13.

@floriangosse
Copy link
Member

floriangosse commented Dec 4, 2017

Thank you. I luckily hadn't the problem.

Could you please change the link to the storybook documentation to the rendered version: https://storybook.js.org/basics/faq/#why-is-there-no-addons-channel. That would be nice. :)

And I see that this could solve the problem with react-native? That is really nice. Do you know what is needed to have support for react-native?

@matteocng matteocng force-pushed the move-addons-to-peer-dependencies branch from cd8b654 to 71b943a Compare December 4, 2017 22:20
@matteocng
Copy link
Contributor Author

matteocng commented Dec 8, 2017

I've changed the link. :)

This PR should eliminate the Accessing nonexistent addons channel issue connected to duplicate instances of the addons module in both Storybook React and Native - obviously all storybook addons distributed in the wild will have to make the switch for this fix to be really effective - but I haven't had the chance to thoroughly test this module with React Native storybook to see if it works.

A super quick test with storybook on Android resulted in Could not find required intl object. <IntlProvider> needs to exist in the component ancestry when applying the decorator, no red screens otherwise (so maybe it's just an intl issue, not specific to this module).

@floriangosse
Copy link
Member

floriangosse commented Jan 5, 2018

Okay. For that we have to check if react-intl has to be used differently in react-native.

Thanks for solving the problem. :-)

@floriangosse floriangosse merged commit 18b8c2f into truffls:master Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants