Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move @storybook/addons to peerDependencies #15

Merged
merged 2 commits into from
Jan 5, 2018
Merged

Move @storybook/addons to peerDependencies #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb4d395
chore: move @storybook/addons to peerDependencies, bump @storybook ve…
matteocng Dec 3, 2017
71b943a
docs: remind to install @storybook/addons, add troubleshooting section
matteocng Dec 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ First, install the addon
npm install -D storybook-addon-intl
```

_Note: Following peer dependencies are required: `@storybook/react`, `react` and `react-intl`._
_Note: Following peer dependencies are required: `@storybook/addons`, `@storybook/react`, `react` and `react-intl`._

Add this line to your `addons.js` file (create this file inside your storybook config directory if needed).

Expand Down Expand Up @@ -57,3 +57,14 @@ addDecorator(withIntl);
// Run storybook
configure(() => require('./stories'), module);
```

## Troubleshooting

##### _Accessing nonexistent addons channel_ error:
This error can be caused by multiple conflicting versions of `@storybook/addons` in your app.

- Ensure that the entries starting with `@storybook/addon-` in your `package.json` refer to the same and latest version.
- Add the latest version of `@storybook/addons` to your app's `dependencies` and reinstall all modules.

If the above steps don't solve the issue, please read the [storybook documentation](https://storybook.js.org/basics/faq/#why-is-there-no-addons-channel) on this topic:
> Most of the time, the fix is deleting the node_modules folder with any package-lock.json or yarn.lock and reinstalling.
7 changes: 4 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,11 @@
},
"homepage": "https://github.com/truffls/storybook-addon-intl#readme",
"dependencies": {
"@storybook/addons": "^3.1.0",
"prop-types": "^15.5.0"
},
"devDependencies": {
"@storybook/react": "^3.1.0",
"@storybook/addons": "^3.2.16",
"@storybook/react": "^3.2.16",
"babel-cli": "^6.14.0",
"babel-jest": "^20.0.3",
"babel-plugin-transform-object-rest-spread": "^6.23.0",
Expand All @@ -47,7 +47,8 @@
"shelljs": "^0.7.4"
},
"peerDependencies": {
"@storybook/react": "^3.1.0",
"@storybook/addons": "^3.2.16",
"@storybook/react": "^3.2.16",
"react": "^15.4.0 || ^16.0.0",
"react-intl": "^2.3.0"
},
Expand Down