Update bootstrap to 2.2.2 (our 2.2.2.0)

[trisweb]

• From update to match v2.2.2 jlong/sass-bootstrap-defunct#44
• Fully scripted to make future updates yet easier.
• Version numbers bumped to 2.2.2.0

[m5o]

Thank you Tristan! This speed is awesome 🚀

[trisweb]

@thomas-mcdonald any ETA on getting this upgrade out?

[philipkobernik]

Thanks @trisweb 🍔

[archonic]

Thanks! This fixes a bug with dropdown links for mobile.

[erikdahlstrand]

Yeah! I'm also waiting for the dropdown fix. Hope this commit can be pulled in soon.

[archonic]

In the meantime you can replace .../gems/bootstrap-sass-x.x/vendor/assets/javascripts/bootstrap-dropdown.js manually with this:
https://raw.github.com/twitter/bootstrap/master/js/bootstrap-dropdown.js

[gdub01]

Ya it sucks to not work on touch devices. Thanks for the fix!

[trisweb]

@thomas-mcdonald ☝️

[jsmestad]

[hayksaakian]

please merge. thanks

[m5o]

Will it arrive before Christmas?

C'mon

[trisweb]

🚢

[trisweb]

Thanks!

[barmstrong]

Weird, I was hoping this would fix our dropdown mobile bug as well, but it didn't seem to work.

I made sure I had the latest:

gem 'bootstrap-sass',              '2.2.2.0', git: 'git://github.com/thomas-mcdonald/bootstrap-sass.git', ref: 'd82477860e1e5d16e9bc32ebfe3c31d432bef920'

And our nav code

<div class="nav-collapse in collapse" style="height: 256px;">
  <ul class="nav">
    <li class=""><a href="/home">Home</a></li>
    <li class=""><a href="/about">About</a></li>
  </ul>

  <ul class="nav pull-right">
      <li class="dropdown">
        <a href="#" class="dropdown-toggle" data-toggle="dropdown"><i class="icon-user"></i> Test User <b class="caret"></b></a>
        <ul class="dropdown-menu">
          <li><a href="/transactions">My Transactions</a></li>
            <li><a href="/admin">Admin Only</a></li>
          <li class="divider"></li>
          <li><a href="/signout" data-method="delete" rel="nofollow">Sign Out</a></li>
        </ul>
      </li>
  </ul>
</div>

This is on coinbase.com if anyone has any ideas (can try it in a shrunk down chrome window). Thanks!

[barmstrong]

Fixed for now with css so it is always open on mobile: twbs/bootstrap#4550 (comment)

But still open to ideas if people have any. Thanks!

[trisweb]

@barmstrong - I had the same problem. 2.2.2 did NOT fix dropdowns on mobile. It's really this pull that will fix it if merged: twbs/bootstrap#6488

Here's a temporary workaround that worked for me. Place this in your JS after the bootstrap JS is loaded:

  // Temp Fix: Remove after Bootstrap does the right thing and removes touchstart (see issue https://github.com/twitter/bootstrap/issues/6488)
  $('a.dropdown-toggle, .dropdown-menu, .dropdown-menu a, .dropdown-menu .dropdown-submenu a').on('touchstart.dropdown.data-api', function (e) {
    e.stopPropagation();
  });

Once a fix is (hopefully) in the next version, we'll pull it in from upstream.

[trisweb]

@barmstrong correction, I'm doing some more research. 2.2.2 did not appear to fix anything for me, though this line from this pull should be the fix: https://github.com/thomas-mcdonald/bootstrap-sass/pull/270/files#L8R157

[jakehockey10]

I'm using version 3.3.3 of this gem and it is still not fixed. Am I missing something?