Remove touchstart from bootstrap-dropdown.js. #6488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
+1 Full disclosure: I'm the FastClick author. |
|
I wholeheartedly agree with removing touchstart from these. cc: #4550 (which is still broken for me) |
|
+1 for consistency sake, just encountered this as well. |
fat
added a commit
that referenced
this pull request
Feb 6, 2013
Remove touchstart from bootstrap-dropdown.js.
|
cool sounds good - thanks guys |
|
@nanek this pull request broke dropdowns for me, particular this line: .on('.dropdown-menu', function (e) { e.stopPropagation() }) which seems a bit strange to keep since you removed the event before .dropdown-menu which as touchstart before. |
|
Jeah updating to 2.3.0 also screwed up my dropdown menus. |
ashtaroth
pushed a commit
to ashtaroth/gwt-bootstrap
that referenced
this pull request
Nov 6, 2013
Fix approach is taken from Twitter Bootstrap 3.0 Twitter Bootstrap bug reports: twbs/bootstrap#4550 twbs/bootstrap#6488
ashtaroth
pushed a commit
to ashtaroth/gwt-bootstrap
that referenced
this pull request
Nov 6, 2013
Fix approach is taken from Twitter Bootstrap 3.0 Twitter Bootstrap bug reports: twbs/bootstrap#4550 twbs/bootstrap#6488
kevinoid
added a commit
to kevinoid/fastclick
that referenced
this pull request
Oct 9, 2014
"Use case 2" in the documentation describes a compatibility issue with Twitter Bootstrap 2.2.2. After reading this, I was unsure about whether the issue only applied to version 2.2.2 or whether this workaround was still required. After some investigation, it appears that the compatibility issue was introduced in twbs/bootstrap@c9cef741 (included in `v2.1.0` and later) and was resolved in twbs/bootstrap@b5ad5068 (included in `v2.3.0` and later, including `v3.0.0`) as a result of twbs/bootstrap#6488. To avoid causing confusion for future users who may not know about the state of this issue, this commit clarifies which versions of Twitter Bootstrap are affected. Signed-off-by: Kevin Locke <[email protected]>
kevinoid
added a commit
to kevinoid/fastclick
that referenced
this pull request
Oct 9, 2014
"Use case 2" in the documentation describes a compatibility issue with Twitter Bootstrap 2.2.2. After reading this, I was unsure about whether the issue only applied to version 2.2.2 or whether this workaround was still required. After some investigation, it appears that the compatibility issue was introduced in twbs/bootstrap@c9cef741 (included in `v2.1.0` and later) and was resolved in twbs/bootstrap@b5ad5068 (included in `v2.3.0` and later, including `v3.0.0`) as a result of twbs/bootstrap#6488. To avoid causing confusion for future users who may not know about the state of this issue, this commit clarifies which versions of Twitter Bootstrap are affected. Signed-off-by: Kevin Locke <[email protected]>
james9909
added a commit
to StuyPulse/bootstrap
that referenced
this pull request
Jun 15, 2017
Causes dropdown events to trigger twice on mobile Reference: twbs#6488
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be great to remove listening to touchstart from the bootstrap dropdowns. This would make it consistent with the rest of the bootstrap components.
It seems like either all clickable elements should be listening for touchstart or none of them should be. I agree with the comment from #3772 (comment)
FastClick works great with Bootstrap except for the bootstrap-dropdowns because they also listen for touchstart which then causes the dropdown to open and then immediately close. See ftlabs/fastclick#48 for more info. Removing touchstart from bootstrap dropdowns would fix this issue and make all of the bootstrap controls behave the same.
Thanks!