-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't scroll to last collapsed navbar item on mobile when there are many items #12738
Comments
Which platforms+versions? |
Also, I presume you're referring to fixed top navbars? |
Yeah, sorry forgot to mention the details since I was discussing this with mdo. Happens with Samsung S4 Android 4.3 FF/built in browser but mdo tried with iphone and he could reproduce. I don't have a jsbin example but you can check http://mpc-hc.org/; the last navbar link, the Donate one doesn't show in landscape mode. I can also reproduce the issue in Google chrome tools when I emulate Samsung S4 in landscape mode. I opened the issue as a reminder for mdo, but I'm not sure he'd like to address this upstream. I mean the docs state that one has to either reduce the number of links or use the responsive utilities for this use case. |
Actually, that docs note is about the non-mobile fully-horizontal navbar. |
Confirmed on iOS 7. Testcase: http://jsbin.com/dovil/1 |
I have an issues with portrait and landscape (Android 2.2.1 - screen 320x480 pixels) doesn't work the scroll in the menu, and also in (Android 4.2.2 - screen 480x854 pixels) landscape, I have the same problem, I can't do the scroll, maybe the problem is this one: .navbar-collapse { |
Regression of #10601. |
Any ideas on how to fix this? I've removed the max-height, but it still happens. It seems this has to do with the |
Here is a JQuery fix... |
I think the only sensible implementation is one that's on top of the core, not in it. We could add a vertical media query based on viewport height, but that's not always going to apply. For example, only fixed headers exhibit this problem, not static ones. We could unfix the fixed navbars to address this, but that sounds lame at this point. I think our best bet is to punt on this until v4 when we can simplify and improve a bit easier. Thoughts? |
* master: Replace some images on the Carousel example with some base64 encoded 1x1 gifs ugh grunt moar grunt mo copy http://www.youtube.com/watch?v=AJWtLf4-WWs grunt Copy change fix grammar in comment in forms.less Fixes #12759 Fixes #12738 replace .visible-{size} with .visible-{size}-{display} ; fixes #8869 Conflicts: dist/css/bootstrap-theme.css.map dist/css/bootstrap.css.map docs/assets/js/customize.min.js docs/assets/js/raw-files.min.js docs/dist/css/bootstrap-theme.css.map docs/dist/css/bootstrap.css.map less/mixins.less
I'm not sure who you're requesting thoughts from, but I definitely agree on punting to v4. This is a fixed header only problem, and flipping this over to a Jquery fix is really easy. |
Thanks @mdo! I tested this locally and seems to work as expected :) |
Do anyone has the same problem that the Menu item cant be scrolled in The listing in the menu exceed the max-height but scroll not coming out/ unable to scroll in the menu. |
@s4jum4 how was your menu? Do you find any solution to the scrolling problem in your Android 2.2.1?? |
Hi @alfredyeap, currently I have the same issue, apparently this issue appear when we are using the menu with fixed option. Thanks @JamieLaing, your code is working better for Android 4+ |
@mdo: I went ahead and tried the latest HEAD on a live site (http://mpc-hc.org/). While on desktop everything works fine in landscape view, on mobile the last navbar item is still hidden. :/ |
I'm gonna reopen this @mdo since the issue is present, unfortunately. |
* Removes default max-height from .navbar-collapse (so not every navbar will get a max-height collapse section) * Scopes regular 340px max-height to fixed top and bottom navbars only (those are the only ones that really need a max-height to enable scrolling) * Adds a landscape media query for phones to cap the max-height at 200px for fixed navbars"
* master: Replace some images on the Carousel example with some base64 encoded 1x1 gifs ugh grunt moar grunt mo copy http://www.youtube.com/watch?v=AJWtLf4-WWs grunt Copy change fix grammar in comment in forms.less Fixes twbs#12759 Fixes twbs#12738 replace .visible-{size} with .visible-{size}-{display} ; fixes twbs#8869 Conflicts: dist/css/bootstrap-theme.css.map dist/css/bootstrap.css.map docs/assets/js/customize.min.js docs/assets/js/raw-files.min.js docs/dist/css/bootstrap-theme.css.map docs/dist/css/bootstrap.css.map less/mixins.less
…dth for .navbar-collapse height in landscape devices
Can confirm this affects browsing on Android 2.3.6. A possible fix taken from this SO answer:
You can test it here: Pros:
Cons:
|
Hi @maniqui! You appear to have posted a live example (http://jsbin.com/gibufafico/edit), which is always a good first step. However, according to Bootlint, your example has some Bootstrap usage errors, which might potentially be causing your issue:
You'll need to fix these errors and post a revised example before we can proceed further. (Please note that this is a fully automated comment.) |
@twbs-lmvtfy: fixed. |
I really need to test this...
|
https://output.jsbin.com/lufuxo == navbar-fixed-top can't get to menu items when the viewport is shorter than the height of the menu on small viewport widths. |
Hi @carasmo! You appear to have posted a live example (https://jsbin.com/lufuxo/edit), which is always a good first step. However, according to Bootlint, your example has some Bootstrap usage errors, which might potentially be causing your issue:
You'll need to fix these errors and post a revised example before we can proceed further. (Please note that this is a fully automated comment.) |
This is still valid. I managed to pinpoint the version where this started to break. 3.1.1 works fine, 3.2.0 and on has the problem. We really need to find a solution for this. |
Actually, scratch that. The issue I see is different than this. Something changed with the navbar's height. |
Adding height and overflow styling with important tag after boostrap css has been included seems to fix problem for me. Here's how : |
I can confirm @Brozeus solution works. |
yaaa @Brozeus that way works very fine |
@Brozeus solution works |
@Brozeus still works. Personally had to change max-height to |
Instead of setting a max-height that may be less than optimal you could go with:
|
thanks @allurewebsolutions, including this by default with https://crocodilejs.com |
This might be even better, so that your nav can go to the bottom if necessary:
|
[Original title: Expanded navbar on mobile (landscape) is cut off]
/CC @mdo
The text was updated successfully, but these errors were encountered: