Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When using input-lg with inputs with a glyphicon, the icon is not vertically centered. #12868

Closed
gespadas opened this issue Feb 27, 2014 · 3 comments
Closed

When using input-lg with inputs with a glyphicon, the icon is not vertically centered. #12868

gespadas opened this issue Feb 27, 2014 · 3 comments
Labels
confirmed css
Milestone
v3.2.0

Comments

@gespadas
Copy link

When using .input-lg with inputs with a glyphicon, the icon is not vertically centered (tested in Firefox and Chrome).

bootstrap-issue-input-lg-glyphicons

I use this snippet and correct the issue:

.input-lg + .glyphicon { margin-top:6px; }

Maybe you should consider include this on the core css.
@cvrebert cvrebert added the css label Feb 27, 2014
@cvrebert cvrebert added this to the v3.2.0 milestone Feb 27, 2014
@mdo mdo closed this as completed in 7733f24 Mar 4, 2014
@gespadas
Copy link
Author

gespadas commented Mar 5, 2014

Awesome! Thanks!

ithcy pushed a commit to stevelaz/bootstrap that referenced this issue Mar 6, 2014
Merge remote-tracking branch 'upstream/master'
d06d0c3 
* upstream/master: (45 commits)
  fix twbs#12936
  Run `grunt update-shrinkwrap`
  [email protected]
  Fixes twbs#12901: Refactors list group active state for use on non-anchors
  nav
  Fixes twbs#12848: Account for and document progress bars at 0-3%
  use full version number in deprecation note
  clarify deprecation /cc @cvrebert
  Fixes twbs#12697: Document readonly inputs
  docs for twbs#12873
  grunt after merging twbs#12917
  Grunt after merging twbs#12863
  grunt
  Fixes twbs#12868: Enables icon feedback on validation states for large/small inputs.
  Fixes twbs#12913: Remove scoped media queries from custom xs grid mixins
  Fixes twbs#12914: Darken immediate children hr elements in jumbotrons
  Fixes twbs#12916: Don't let .lead resize on viewport change
  add svg logos to brand guidelines
  Update csscomb properties. 'colon-spac'e and 'stick-brace' don't take boolean values.
  grunt
  ...

Conflicts:
	dist/css/bootstrap.css.map
	dist/css/bootstrap.min.css
@mdo mdo mentioned this issue Mar 7, 2014
Closed
stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014
@mdo
(less) Fixes twbs#12868: Enables icon feedback on validation states f…
5ae4985 
…or large/small inputs.

Also reorders the CSS to place Glyhpicons as a dependency before other components for fewer overrides and less specific CSS.
@plmarcelo
Copy link

This fix doesn't seems to work for input-group fields.

I fixed using:

.input-group-lg + .form-control-feedback {
width: @input-height-large;
height: @input-height-large;
line-height: @input-height-large;
}

.input-group-sm + .form-control-feedback {
width: @input-height-small;
height: @input-height-small;
line-height: @input-height-small;
}

@kkirsche
Copy link
Contributor

@plmarcelo I'd recommend making a new issue for what you've stated and posting a JSBin of the issue.

hnrch02 added a commit that referenced this issue Mar 1, 2015
@hnrch02
Input group sizes: Properly position .form-control-feedback
fd35779 
Ref #12868 (comment)
Ref 7733f24
@hnrch02 hnrch02 mentioned this issue Mar 1, 2015
Merged
@twbs twbs locked and limited conversation to collaborators Mar 2, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
confirmed css
Projects
None yet
Milestone
v3.2.0
Development

No branches or pull requests
4 participants
@gespadas @plmarcelo @cvrebert @kkirsche