Wrong(?) media queries in .make-xs-column-*

[nenebale]

Hi :)

The media queries in the three .make-xs-column-* mixins make them ineffective under a viewport width of @screen-xs-min.

Am I using them wrong (see example below) or are this media queries misplaced?

Thank you for your help!

My code:

.logo {
  background: url('logo-text.svg') left top no-repeat;
  background-size: 100% auto;
  height: 200px;

  @include make-xs-column(8);
  @include make-xs-column-offset(2);

  @include make-sm-column(5);
  @include make-sm-column-offset(3.5);

  @include make-md-column(4);
  @include make-md-column-offset(4);

  @include make-lg-column(3);
  @include make-lg-column-offset(4.5);
}

Mixins:

.make-xs-column-offset(@columns) {
  @media (min-width: @screen-xs-min) {
    margin-left: percentage((@columns / @grid-columns));
  }
}
.make-xs-column-push(@columns) {
  @media (min-width: @screen-xs-min) {
    left: percentage((@columns / @grid-columns));
  }
}
.make-xs-column-pull(@columns) {
  @media (min-width: @screen-xs-min) {
    right: percentage((@columns / @grid-columns));
  }
}

[cvrebert]

I agree that this seems strange. The very concept of @screen-xs-min sounds wonky; there isn't supposed to be a minimum width for an XS screen, only a maximum (the boundary between it and SM screens). I suppose the grid column padding de facto imposes a minimum though, but even that's 360px, not 480px like @screen-xs-min.

X-Ref #11228 ?

[mdo]

Yeah, seems we should probably remove the media queries there, right? The grid.less xs tier is unbound (no media queries at all).

[cvrebert]

@mdo Shouldn't we also deprecate @screen-xs-min?

[mdo]

Added a comment, not sure what else there is do.

[cvrebert]

That should be sufficient. 😄 After your other changes, we don't use that var anywhere anymore.

[carasmo]

@media (max-device-width: @screen-xs-min) and (orientation: landscape) this is used in the navbars.less -- what is the replacement for @screen-xs-min? Thanks!

[cvrebert]

@carasmo There isn't one, because the concept is absurd. There is no maximum for the LG breakpoint, and there is symmetrically no minimum for the XS breakpoint.

[carasmo]

Ahh, yes I get why it's absurd, but what do you put here in the navbars.less file for @media (max-device-width: @screen-xs-min) and (orientation: landscape) if it's gone? Just leave as is?

[cvrebert]

It's a hack for something. Should be gone in v4 when we're able to redo navbars.