Why doesn't use .sr-only in spinner?

[ysds]

https://twbs-bootstrap4.netlify.com/docs/4.1/components/spinners/#about

For accessibility purposes, ...., using a text hiding technique to prevent it from rendering on screen.

Text hide technique is not a modern approach (#24890). IMO we should use .sr-only to hide Loading... text:

<div class="spinner-border" role="status"><span class="sr-only">Loading...</span></div>

[patrickhlauke]

don't think there's any particular disadvantage to how it's done now. my comment about modern/not modern was to do with text-hide as a class/old-school image replacement techniques

[ysds]

@patrickhlauke Thanks for your reply. Current the text-indent: -999em; technique is a outdated technique, the html5-boilerplate technique is better. But that is the same with the deprecated text-hide() mixin. If deprecate the text-hide() minix, we should use .sr-only for consistency.

[mdo]

@ysds Honestly did it the way it’s currently implemented because it’s engrained in my head to do it that way hah. We can definitely use .sr-only.

[XhmikosR]

Can someone make a PR?

[ysds]

Leave it to me 🙂