Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use .sr-only instead of text-hide technique #27736

Merged
merged 6 commits into from
Dec 4, 2018
Merged

Use .sr-only instead of text-hide technique #27736

merged 6 commits into from
Dec 4, 2018

Conversation

ysds
Copy link
Member

@ysds ysds commented Nov 28, 2018 •
edited by XhmikosR
Loading

Fixes #27727

I used the former, but which do you prefer?

<div class="spinner-border" role="status">
  <span class="sr-only">Loading...</span>
</div>

or

<span class="spinner-border" role="status" aria-hidden="true"></span>
<span class="sr-only">Loading...</span>

Netlify docs

@ysds ysds requested a review from a team as a code owner November 28, 2018 11:30
MartijnCuppens
MartijnCuppens approved these changes Dec 3, 2018
View reviewed changes
Copy link
Member

@MartijnCuppens MartijnCuppens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSS-wise it LGTM

patrickhlauke
patrickhlauke approved these changes Dec 3, 2018
View reviewed changes
Copy link
Member

@patrickhlauke patrickhlauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (though see my suggested rewording...not essential / matter of taste though, so not critical)

site/docs/4.1/components/spinners.md Outdated Show resolved Hide resolved
@XhmikosR XhmikosR merged commit e9ec5e7 into twbs:v4-dev Dec 4, 2018
@ysds ysds deleted the spinner-sr-only branch December 4, 2018 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartijnCuppens MartijnCuppens MartijnCuppens approved these changes

@patrickhlauke patrickhlauke patrickhlauke approved these changes

Assignees
No one assigned
Labels
css v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ysds @patrickhlauke @MartijnCuppens @XhmikosR