-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: stretched link #26184
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
108474c
to
bb7b69b
Compare
d8666e3
to
3007d4b
Compare
@MartijnCuppens Just to let you know that we can't select text in element containing a stretched link. Is this a known restriction? |
@florianlacreuse, that's a known restricting. You can't select text in a link either (eg. see https://codepen.io/MartijnCuppens/pen/GwbWjp) |
I'd like to bring this back for v4.2. Looking at it though, I wonder if we should do more to discourage multiple links and modifying their |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some copy suggestions here to be more specific.
Thanks for the copy changes, @mdo. Feel free to add an appropriate warning, I don't know if we should keep the example with the multiple links, because people might just copy paste this bad example? |
The copy changes are looking good, thanks @mdo! |
Build is failing because this is stuck in the |
de7a382
to
c288af6
Compare
c288af6
to
bf7483d
Compare
This was merged directly apparently. I don't agree with that solution since GH allows us to push to forks and pushing directly does NOT run the tests. Let alone you didn't squash. |
|
I agree, the |
@mdo: please disable merge commits for the whole repo. I'd also suggest that you disable direct pushes for admins too, no offense but you know :P Joking aside, I don't know, you can leave the merge option although we don't really use it. I'm more concerned about the direct pushes. |
@mdo I know this is closed, but I think you meant "its containing block" instead of "it's containing block" on line eight of |
Fixes #18294
Stretched links can make whole cards or other elements clickable. This PR is based on #25087, but can be used in multiple situations, not only cards.
Demo: https://deploy-preview-26184--twbs-bootstrap4.netlify.com/docs/4.1/utilities/stretched-link/