Blacklist border-radius property (use mixin instead) #27900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartijnCuppens
commented
Dec 22, 2018
| @@ -200,10 +200,12 @@ | |||
|
|
|||
| .card-img-top, | |||
| .card-header { | |||
| // stylelint-disable-next-line property-blacklist | |||
| border-top-right-radius: 0; | |||
There was a problem hiding this comment.
Not sure if we should add a mixin for border-top-right-radius and the other specific border radii?
There was a problem hiding this comment.
Eh, probably not necessary? It'd save on a bit of CSS when folks compile without rounded corners enabled, but probably not worth it right now.
MartijnCuppens
commented
Dec 22, 2018
| @@ -144,6 +144,7 @@ | |||
|
|
|||
| .custom-radio { | |||
| .custom-control-label::before { | |||
| // stylelint-disable-next-line property-blacklist | |||
There was a problem hiding this comment.
I guess the custom radios should always be round, independent of $enable-rounded? That's why I didn't use the mixin here.
MartijnCuppens
commented
Dec 22, 2018
| } @else { | ||
| border-radius: 0; | ||
| } | ||
| @include border-radius($custom-select-border-radius, 0); |
There was a problem hiding this comment.
I didn't really like the if/else statement here, so I tweaked the border-radius mixin a bit to simplify this code here.
mdo
approved these changes
Dec 22, 2018
Closed
bkdotcom
added a commit
to bkdotcom/bootstrap
that referenced
this pull request
Jan 3, 2019
* v4-dev: (56 commits) Remove unnecessary brackets for consistency (twbs#27966) Fix Typo on docs (twbs#27962) Add a few more redirects. Remove wrapping paragraph in readme (twbs#27948) Configurable display utility classes (twbs#27917) Fix custom select font sizes (twbs#27929) Match input font size for `.input-group-text` (twbs#27941) reboot: Fix comment (twbs#27937) Fix form-feedback-icon-invalid color (twbs#27935) toasts: mention that positioning is manual. (twbs#27931) stretched-link.md: fix typo (twbs#27918) Add Open Collective to header (twbs#27916) Add horizontal card example (twbs#27906) getSelectorFromElement return null on bad selectors (twbs#27912) versions: sort from newer to older. (twbs#27898) Fix 4:3 embed (twbs#27910) Simplify card group css (twbs#27901) Blacklist border-radius property (use mixin instead) (twbs#27900) move to 4.2 bootstrap-stack.svg: remove unneeded space. ...
pascalpepe
referenced
this pull request
in pascalpepe/bootstrap-webpack-template
Jan 1, 2020
* Upgrade Bootstrap to version 4.3.1. * Upgrade the following development dependencies: - **autoprefixer** to version 9.4.7 - **nodemon** to version 1.18.10" - **stylelint** to version 9.10.1" - **stylelint-config-twbs-bootstrap** to version 0.3.0 * Move PostCSS config file from the ``build/`` directory to the repository root. * Added new rules in the config of **stylelint** in order to blacklist some ``border-radius`` properties (use Bootstrap's mixin instead, see `Bootstrap issue #27900 <https://github.com/twbs/bootstrap/pull/27900>`_).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing on #27883 (comment). Blacklist the border radius property in stylelint, so we don't accidentally add this like happend with the toasts.