Fix custom select font sizes #27929
Merged
Fix custom select font sizes #27929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdo
approved these changes
Dec 28, 2018
XhmikosR
deleted the
v4-dev-martijncuppens-fix-custom-select-font-sizes
branch
Closed
bkdotcom
added a commit
to bkdotcom/bootstrap
that referenced
this pull request
Jan 3, 2019
* v4-dev: (56 commits) Remove unnecessary brackets for consistency (twbs#27966) Fix Typo on docs (twbs#27962) Add a few more redirects. Remove wrapping paragraph in readme (twbs#27948) Configurable display utility classes (twbs#27917) Fix custom select font sizes (twbs#27929) Match input font size for `.input-group-text` (twbs#27941) reboot: Fix comment (twbs#27937) Fix form-feedback-icon-invalid color (twbs#27935) toasts: mention that positioning is manual. (twbs#27931) stretched-link.md: fix typo (twbs#27918) Add Open Collective to header (twbs#27916) Add horizontal card example (twbs#27906) getSelectorFromElement return null on bad selectors (twbs#27912) versions: sort from newer to older. (twbs#27898) Fix 4:3 embed (twbs#27910) Simplify card group css (twbs#27901) Blacklist border-radius property (use mixin instead) (twbs#27900) move to 4.2 bootstrap-stack.svg: remove unneeded space. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The font sizes of custom selects are unchangeable. This PR syncs the custom select font size with
$input-font-size.Also
$custom-select-font-size-smis$input-btn-font-size-smby default, while it should be$input-btn-font-size. Same for$custom-select-font-size-lg.