Update 1-click install script to use /tags endpoint instead of /release #8689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Modified the 1-click install script to use GitHub's /tags endpoint instead of /releases/latest for more accurate version detection, particularly for sub-version releases.
- Updated API endpoint in
/packages/twenty-docker/scripts/1-click.shto fetch latest tag usingcurl -s https://api.github.com/repos/twentyhq/twenty/tags - Added parsing logic with
grepandheadto extract the most recent tag version - Maintains compatibility with version-specific install script locations (v0.32.4 and newer)
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -1,4 +1,4 @@ | |||
| pull_version=${VERSION:-$(curl -s https://api.github.com/repos/twentyhq/twenty/releases/latest | grep '"tag_name":' | cut -d '"' -f 4)} | |||
| pull_version=${VERSION:-$(curl -s https://api.github.com/repos/twentyhq/twenty/tags | grep '"name":' | head -n 1 | cut -d '"' -f 4)} | |||
There was a problem hiding this comment.
style: Consider adding error handling if the curl command fails or returns no tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the API endpoint from https://api.github.com/repos/twentyhq/twenty/releases/latest to https://api.github.com/repos/twentyhq/twenty/tags.
Related Issue #8679