Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds three packages:
packages/language-server
- a language server supporting hbs template:packages/vscode
- a Visual Studio Code extension for@glint/language-server
test-packages/demo-ember-app
- an Ember app to demonstrate@glint/language-server
To see the language server in action:
yarn
andyarn build
in the glint repo to build all packagespackages/vscode
in VSCodetest-packages/demo-ember-app
app/components/foo.hbs
Notes:
packages/language-server/src/load-typescript.ts
was lifted verbatim frompackages/cli
. We should probably put this somewhere it can be shared.packages/language-server/src/transform-manager.ts
is based on (but, at this point, pretty different from)packages/cli/transform-manager.ts
. There may be some opportunities for factoring out shared bits.packages/language-server/src/glint-language-server.ts
andpackages/language-server/src/transform-manager.ts
.packages/language-server/src/glint-language-server.ts
andpackages/language-server/src/transform-manager.ts
are where I'd like them to be, but gotta start somewhere!packages/language-server/src/glint-language-server.ts
is the correct name for this file/class, but names are hard.