Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR begins with the
@glint/vscode
extension that @jamescdavis set up in #40 and then layers on a few tweaks and gets a basic integration test set up. Unit tests don't buy us much here since essentially all of the code is just glue between Code and the language server.Notes:
?w=1
/"hide whitespace changes", as there are a couple chunks where just indentation changed__tests__/support
to handle launching Jest within Code's test harness. There are some folks experimenting with packaging something up for more easily getting that working (see Add jest-runner microsoft/vscode-test#59 and linked issues), but nothing's quite there yet and for now this suits our purposes..vscode/launch.json
configuration for launching a debug Code instance with the under-development extension