Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VS Code extension #51

Merged
merged 16 commits into from
Mar 1, 2021
Merged

Add VS Code extension #51

merged 16 commits into from
Mar 1, 2021

Conversation

dfreeman
Copy link
Member

This PR begins with the @glint/vscode extension that @jamescdavis set up in #40 and then layers on a few tweaks and gets a basic integration test set up. Unit tests don't buy us much here since essentially all of the code is just glue between Code and the language server.

Notes:

  • This diff is a bit more consumable with ?w=1/"hide whitespace changes", as there are a couple chunks where just indentation changed
  • There's a bit of boilerplate under __tests__/support to handle launching Jest within Code's test harness. There are some folks experimenting with packaging something up for more easily getting that working (see Add jest-runner microsoft/vscode-test#59 and linked issues), but nothing's quite there yet and for now this suits our purposes.
  • This now supports multi-root workspaces by launching a language server per root (which is the recommended approach. We still don't support multiple TypeScript/Glint projects within a root, which is valuable for monorepos and/or composite projects, and is something we should likely investigate further.
  • The repo root now contains .vscode/launch.json configuration for launching a debug Code instance with the under-development extension

@dfreeman dfreeman added the enhancement New feature or request label Feb 27, 2021
@dfreeman dfreeman requested a review from jamescdavis February 27, 2021 16:06
@dfreeman dfreeman merged commit e06775b into master Mar 1, 2021
@dfreeman dfreeman deleted the vscode-extension branch March 1, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants