Add --no-backup option to databse:copy and database:copy:all (#125)

* Create a moveDbs() function that does not backup dbs first and read --no-backup option for database:copy:all. * Add --no-backup option to single database:copy. * Combine backupAndMoveDbs() and moveDbs() into one method. * Create move DBs no backup tests. * Remove $backup var declaration from function call.
typhonius · Oct 17, 2020 · 12ca1d8 · 12ca1d8
1 parent 54f467f
commit 12ca1d8
Show file tree

Hide file tree

Showing 4 changed files with 47 additions and 9 deletions.
diff --git a/src/Commands/AcquiaCommand.php b/src/Commands/AcquiaCommand.php
@@ -221,11 +221,15 @@ protected function waitForNotification($response)
     }
 
     /**
+     * Copy all DBs from one environment to another.
+     *
      * @param string              $uuid
      * @param EnvironmentResponse $environmentFrom
      * @param EnvironmentResponse $environmentTo
+     * @param null|string         $dbName The DB to move, if null move all DBs.
+     * @param boolean             $backup Whether to backup DBs first.
      */
-    protected function backupAndMoveDbs($uuid, $environmentFrom, $environmentTo, $dbName = null)
+    protected function moveDbs($uuid, $environmentFrom, $environmentTo, $dbName = null, $backup = true)
     {
         if (null !== $dbName) {
             $this->cloudapi->addQuery('filter', "name=${dbName}");
@@ -236,7 +240,9 @@ protected function backupAndMoveDbs($uuid, $environmentFrom, $environmentTo, $db
         $this->cloudapi->clearQuery();
 
         foreach ($databases as $database) {
-            $this->backupDb($uuid, $environmentTo, $database);
+            if ($backup) {
+                $this->backupDb($uuid, $environmentTo, $database);
+            }
 
             // Copy DB from prod to non-prod.
             $this->say(

diff --git a/src/Commands/DbCommand.php b/src/Commands/DbCommand.php
@@ -106,10 +106,16 @@ public function dbTruncate(Databases $databaseAdapter, $uuid, $dbName)
      * @param string $dbName
      *
      * @command database:copy
+     * @option no-backup Do not backup the databases on production.
      * @aliases db:copy
      */
-    public function dbCopy($uuid, $environmentFrom, $environmentTo, $dbName)
-    {
+    public function dbCopy(
+        $uuid,
+        $environmentFrom,
+        $environmentTo,
+        $dbName,
+        $options = ['no-backup']
+    ) {
         $environmentFrom = $this->cloudapiService->getEnvironment($uuid, $environmentFrom);
         $environmentTo = $this->cloudapiService->getEnvironment($uuid, $environmentTo);
 
@@ -123,7 +129,11 @@ public function dbCopy($uuid, $environmentFrom, $environmentTo, $dbName)
                 )
             )
         ) {
-            $this->backupAndMoveDbs($uuid, $environmentFrom, $environmentTo, $dbName);
+            if (!$options['no-backup']) {
+                $this->moveDbs($uuid, $environmentFrom, $environmentTo, $dbName);
+            } else {
+                $this->moveDbs($uuid, $environmentFrom, $environmentTo, $dbName, false);
+            }
         }
     }
 
@@ -135,10 +145,15 @@ public function dbCopy($uuid, $environmentFrom, $environmentTo, $dbName)
      * @param string $environmentTo
      *
      * @command database:copy:all
+     * @option no-backup Do not backup the databases on production.
      * @aliases db:copy:all
      */
-    public function dbCopyAll($uuid, $environmentFrom, $environmentTo)
-    {
+    public function dbCopyAll(
+        $uuid,
+        $environmentFrom,
+        $environmentTo,
+        $options = ['no-backup']
+    ) {
         $environmentFrom = $this->cloudapiService->getEnvironment($uuid, $environmentFrom);
         $environmentTo = $this->cloudapiService->getEnvironment($uuid, $environmentTo);
 
@@ -151,7 +166,11 @@ public function dbCopyAll($uuid, $environmentFrom, $environmentTo)
                 )
             )
         ) {
-            $this->backupAndMoveDbs($uuid, $environmentFrom, $environmentTo);
+            if (!$options['no-backup']) {
+                $this->moveDbs($uuid, $environmentFrom, $environmentTo);
+            } else {
+                $this->moveDbs($uuid, $environmentFrom, $environmentTo, null, false);
+            }
         }
     }
 }
diff --git a/src/Commands/DeployCommand.php b/src/Commands/DeployCommand.php
@@ -35,7 +35,7 @@ public function deployPrepare($uuid, $environmentTo, $environmentFrom = null)
 
         $environmentTo = $this->cloudapiService->getEnvironment($uuid, $environmentTo);
 
-        $this->backupAndMoveDbs($uuid, $environmentFrom, $environmentTo);
+        $this->moveDbs($uuid, $environmentFrom, $environmentTo);
         $this->copyFiles($uuid, $environmentFrom, $environmentTo);
     }
 }
diff --git a/tests/Commands/DbCommandTest.php b/tests/Commands/DbCommandTest.php
@@ -33,6 +33,11 @@ public function dbProvider()
 >  Moving DB (database1) from Stage to Dev
 >  Backing up DB (database2) on Dev
 >  Moving DB (database2) from Stage to Dev
+TEXT;
+
+        $dbCopyNoBackup = <<<TEXT
+>  Moving DB (database1) from Stage to Dev
+>  Moving DB (database2) from Stage to Dev
 TEXT;
 
         return [
@@ -59,6 +64,14 @@ public function dbProvider()
             [
                 ['database:copy:all', 'devcloud:devcloud2', 'test', 'dev'],
                 $dbCopy . PHP_EOL
+            ],
+            [
+                ['database:copy', 'devcloud:devcloud2', 'test', 'dev', 'dbName', '--no-backup'],
+                $dbCopyNoBackup . PHP_EOL
+            ],
+            [
+                ['database:copy:all', 'devcloud:devcloud2', 'test', 'dev', '--no-backup'],
+                $dbCopyNoBackup . PHP_EOL
             ]
         ];
     }