Add --no-backup option to databse:copy and database:copy:all

[earthday47]

Resolves #124

[typhonius]

Good idea - thanks for your contribution!

Couple of small comments.

• Please add tests (I've written tests for most of the other methods so you should be able to add another item to https://github.com/typhonius/acquia_cli/blob/master/tests/Commands/DbCommandTest.php to get expected output. You can run the tests locally with composer test
• Can we also alter the backupAndMoveDbs method to use your new moveDbs method so we're doing all db moving in one place.
• I've got no-backup functionality in the code deploy task.

  acquia_cli/src/Commands/CodeCommand.php

  Line 89 in 75a5126

  if (!$options['no-backup']) {

  so I think you could alter your commit to use if (!$options['no-backup']) { for consistency.
• Couple of minor phpcs fixes that have been identified by CI.

FILE: ...ome/travis/build/typhonius/acquia_cli/src/Commands/DbCommand.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 129 | ERROR | [x] Expected 1 space after closing brace; newline
     |       |     found
 163 | ERROR | [x] Expected 1 space after closing brace; newline
     |       |     found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

[typhonius]

I've also just switched CI over to GitHub Actions so if you rebase your branch against master you should get some improved code reviews/checks.

[earthday47]

hi @typhonius thank you! All of your feedback sounds good to me, I'll get to work on them

[earthday47]

Updated with tests... it looks like my force push cancelled the GitHub checks, but composer test is clean on my local.

[typhonius]

Thanks, I’ve seen that error on other PRs and looks like it’s an unrelated step later where we rebuild the phar tool. I’ll push an update later on today because I have an inkling about how to fix it.

[typhonius]

If you are able to rebase (again) against master and fix the following two minor changes then I'll merge it :)

[typhonius]

Switch $backup = false to just false.

[typhonius]

Switch $backup = false to just false.

[earthday47]

All green! 😁
Thanks for your attention and quick review of this request - we already use the CLI as a crucial part of our workflow and this will only help improve it more.