Removes method parameter protection analysis #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msridhar
changed the title
msridhar
approved these changes
Jul 10, 2022
There was a problem hiding this comment.
🎉 LGTM, but I will let @lazaroclapp do the merge in case I missed some issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the method parameter protection feature from NullAway. This feature enables us to make
NullAwayto assume all method parameters at given index are@Nullablewhile processing the method bodies. However, this feature is not used by the other tool (Annotator) which had the first motivation toward implementing this feature.In previous versions of Annotator, processing of method parameters was performed in a different manner compared to all other code locations and was using this specific feature. However, in every version upper that
1.3.0-LOCALthis feature is not used anymore.After this PR the following entity will be removed from the config
.xmlfile: