Preparing for upcoming release of NullAway (0.9.9) #15
Conversation
| @@ -61,7 +62,7 @@ public static Factory<Fix> factory(FieldDeclarationAnalysis analysis) { | |||
| field.variables.addAll(variables); | |||
| }); | |||
| } | |||
| return new Fix(new Change(location, infos[7], true), infos[6], infos[8], infos[9]); | |||
| return new Fix(new Change(location, config.nullableAnnot, true), info[6], info[8], info[9]); | |||
There was a problem hiding this comment.
Just to make sure, all fixes will have "nullable" on their 7th TSV position, right? There aren't currently any "nonnull" fixes or any other kind of fix entries? Maybe worth a Preconditions.checkArgument(info[7].equals("nullable")) before this line, just to guard against that ever changing?
There was a problem hiding this comment.
Yes exactly, sure sounds good. This will remind us to change this part if we ever work on new annotations.
There was a problem hiding this comment.
FYI, the tests on CI are going to fail since it is using the maven central version of NullAway, and the precondition above is causing the termination with error.
There was a problem hiding this comment.
@lazaroclapp For unknown reason, github does nothing when I re-request a review from you, please find the changes applied to your comment.
There was a problem hiding this comment.
FYI, the tests on CI are going to fail since it is using the maven central version of NullAway, and the precondition above is causing the termination with error.
Um, I imagine you want to make other changes to the auto-annotator, so probably we don't want to delay landing this. If we had more than one user for this project, the right call would probably to version our TSV formats and keep support for both versions for a while, but I guess that's overkill here. At the same time, I don't think the preconditions check is worth dealing with a broken CI...
I think my suggestion here would be to comment out the preconditions check with a TODO+Issue to re-enable it once NullAway 0.9.9 has been released. It's a bit hacky, but preferable to all the alternatives above. Apologies for the bikeshedding :)
Encountered an issue #17 while running this |
This PR updates
Annotatorto work with the upcoming release ofNullAway 0.9.9.Through PR621 and PR622 NullAway had the following changes:
NullAwayand the config file for fix serialization has changed.NullAwaywill no longer serialize the actual@Nullableannotation, it only suggests the name of the annotation (e.g.nullable) followed by a change in fix serialization config file.All changes above has been addressed in this PR.