Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wasm light client contains invalid opcodes #91

Closed
benluelo opened this issue May 24, 2023 · 0 comments · Fixed by #92
Closed

Wasm light client contains invalid opcodes #91

benluelo opened this issue May 24, 2023 · 0 comments · Fixed by #92
Assignees
@benluelo

Comments

@benluelo
Copy link
Contributor

We recently upgraded our pinned rust nightly version, which inadvertently broke the wasm light client build:

panic: Error calling the VM: Error during static Wasm validation: Wasm bytecode could not be deserialized. Deserialization error: "Unknown opcode 192": create wasm contract failed

See this issue for more information.
@benluelo benluelo self-assigned this May 24, 2023
@benluelo benluelo mentioned this issue May 24, 2023
Merged
benluelo added a commit that referenced this issue May 26, 2023
@benluelo
fix: ensure no invalid opcodes in wasm light client binary (#92)
82ad5ef 
also added a check to ensure that sign-ext opcodes don't find their way
back into the binary.

this also provides a significant improvement to the size of the binary,
from 2.8M to 1.1M (758K to 322K gzipped).

closes #91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benluelo benluelo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ensure no invalid opcodes in wasm light client binary unionlabs/union
1 participant
@benluelo