Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grant Digest Email Metrics: Disable click-tracking for magic links #3097

Closed
TylerHendrickson opened this issue May 24, 2024 · 1 comment
Closed
Assignees
Labels
good first issue Good for newcomers Grant Finder Issues related to the Grant Finder javascript Pull requests that update Javascript code metrics

Comments

@TylerHendrickson
Copy link
Member

TylerHendrickson commented May 24, 2024

Subtask of User Story: Grant Digest Email Metrics #2749

Blocked by

N/A

Blocks

Definition of Done

When magic links sent in passcode-type login emails are clicked, the click event does not show up in SES event logs.

Implementation details

  • SES click event payloads (example) provide the hyperlink that was clicked. Since magic links contain credentials, they are considered sensitive and should be excluded from email event logs.
  • The ses:no-track HTML attribute can be added to anchor tags in order to disable click-tracking for that particular link in an email. Since this is a nonstandard HTML attribute, SES will remove it from the email body before sending.
    • Example <a ses:no-track href="https://example.com">Clicks for this link will not be tracked!</a>
  • In the sendPasscode() function of packages/server/src/lib/email.js, Add the ses:no-track HTML attribute to the <a> tag that provides the "magic link" in passcode emails.
@TylerHendrickson TylerHendrickson added Grant Finder Issues related to the Grant Finder javascript Pull requests that update Javascript code metrics labels May 24, 2024
@TylerHendrickson TylerHendrickson moved this from 🆕 New to 🔖 Ready in Grants Team Agile Planning May 24, 2024
@TylerHendrickson TylerHendrickson added the good first issue Good for newcomers label May 24, 2024
@thucdtran thucdtran self-assigned this Jun 11, 2024
@thucdtran thucdtran moved this from 🔖 Ready to 🏗 In progress in Grants Team Agile Planning Jun 11, 2024
@thucdtran thucdtran moved this from 🏗 In progress to 👀 In review in Grants Team Agile Planning Jun 12, 2024
@thucdtran thucdtran moved this from 👀 In review to ✅ Staging in Grants Team Agile Planning Jun 18, 2024
@ClaireValdivia ClaireValdivia moved this from ✅ Staging to 🚢 Completed in Grants Team Agile Planning Jun 20, 2024
@TylerHendrickson
Copy link
Member Author

Closed by #3163

@github-project-automation github-project-automation bot moved this from 🚢 Completed to ✅ Staging in Grants Team Agile Planning Sep 3, 2024
@TylerHendrickson TylerHendrickson moved this from ✅ Staging to 🚢 Completed in Grants Team Agile Planning Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Grant Finder Issues related to the Grant Finder javascript Pull requests that update Javascript code metrics
Projects
Archived in project
Development

No branches or pull requests

2 participants