-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable click tracking for magic links #3163
Merged
thucdtran
merged 3 commits into
main
from
thucdtran/disable-click-tracking-for-magic-links
Jun 15, 2024
Merged
Disable click tracking for magic links #3163
thucdtran
merged 3 commits into
main
from
thucdtran/disable-click-tracking-for-magic-links
Jun 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ucdtran/disable-click-tracking-for-magic-links
github-actions
bot
added
the
javascript
Pull requests that update Javascript code
label
Jun 12, 2024
thucdtran
changed the title
Thucdtran/disable click tracking for magic links
Disable click tracking for magic links
Jun 12, 2024
QA Summary
Test CoverageCoverage report for `packages/client`
Coverage report for `packages/server`
|
Terraform Summary
Hint: If "Terraform Format & Style" failed, run OutputValidation Output
Plan Summary
Pusher: @thucdtran, Action: |
TylerHendrickson
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket #3097
Description
Adding the ses:no-track attribute to disable click tracking for magic links.
Screenshots / Demo Video
N/A
Testing
Tested to see if the attribute was included on the email's payload.
Steps:
docker compose exec app yarn workspace server run send-debug-email
with emailType: login passcodeses:no-track
attributeAutomated and Unit Tests
For this, do we want to have an explicit unit test that checks for the presence of
ses:no-track
somewhere in the email's payload?Manual tests for Reviewer
Checklist