Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix version number in SwzDeviceFeed examples #240

Merged
merged 1 commit into from
Mar 10, 2022
Merged

Fix version number in SwzDeviceFeed examples #240

merged 1 commit into from
Mar 10, 2022

Conversation

j-d-b
Copy link
Collaborator

@j-d-b j-d-b commented Feb 2, 2022

Resolves #239 by changing the version number in the SwzDeviceFeed example JSON files from "1.0" to "4.0".

@j-d-b j-d-b requested a review from mark-mockett February 2, 2022 00:41
@j-d-b j-d-b added Non-spec This issue is not related to the specification content Simple This issue is can be easily resolved/implemented Single Approval This non-spec item can be merged after review by a single maintainer labels Feb 2, 2022
@j-d-b j-d-b requested a review from mollybehan March 9, 2022 04:23
@j-d-b j-d-b merged commit 7162dad into main Mar 10, 2022
@j-d-b j-d-b deleted the issue/swz-device-feed-example branch March 10, 2022 13:22
j-d-b added a commit that referenced this pull request Mar 20, 2022
@j-d-b
Fix version in SwzDeviceFeed examples (#240)
9351cba
j-d-b added a commit that referenced this pull request Mar 21, 2022
@j-d-b
Fix version in SwzDeviceFeed examples (#240)
68b4797
j-d-b added a commit that referenced this pull request Mar 21, 2022
@j-d-b
Fix merge conflicts between main and v4.1 release branch (#272)
061468a 
* Fix Releases section heading level (#226)

* Fix version in SwzDeviceFeed examples (#240)
j-d-b added a commit that referenced this pull request Sep 19, 2022
@mark-mockett @j-d-b
@jlarsonOmahaNE @sknick-iastate @dxpack
Release WZDx v4.1 (#335)
5952f21 
* Deprecate is_moving on ArrowBoard

* Add v4.1 schema

* Update current schema version

* Fix schema directory name

* Update documentation to prepare for v4.1

* Add is_moving to FieldDeviceCoreDetails

* Change TrafficSensorLaneData road_event_id to optional

* Update schema IDs

* Set up for v4.1 release (#265)

* Add v4.1 schema

* Update current schema version

* Fix schema directory name

* Update documentation to prepare for v4.1

* Update schema IDs

* Change TrafficSensorLaneData road_event_id to optional

* Fix SwzDeviceFeed schema

* Fix merge conflicts between main and v4.1 release branch (#272)

* Fix Releases section heading level (#226)

* Fix version in SwzDeviceFeed examples (#240)

* Add road_direction to FieldDeviceCoreDetails

* Use road_direction in SwzDeviceFeed examples

* Add UUID recommendation to FeedDataSource and RoadEventFeature

* Add name property to RoadEventCoreDetails

* Use UUID and name in feed examples

* Use boolean properties for position verification

* Update examples to use boolean position verification properties

* Add deprecation note to SpatialVerification

* Fix property name

* Drop gps from is_startend_position_verified

* Allow feed_info for WZDxFeed

* Add notes to static_sign_text about requirement

* Add personal-device MarkedLocationType

* Deprecate event_status

* Replace start and end accuracy with verified boolean

* Add deprecation note to TimeVerification

* Update deprecation note in EventStatus

* Fix schema conditional requirements

* Complete fix schema conditional requirement

* Fix schema conditional requirement

* Add implementation guidance for completed road events

* Update FieldDeviceCoreDetails update_date description

* Update RoadEventCoreDetails update_date description

* Adding undefined and unknown values

Add undefined and unknown to the direction enumerated types to allow for no road direction and if the producer does not know affected direction of travel.

* Updating descriptions of undefined and unknown

* Adding RoadEventFeature link

* Updating schema to include new values

* Adding the no-passing enumerated type

Per Issue #215

* Adding the new no-passing value to the schema

* Add optional sign_text property to FlashingBeacon

* Change field device road_names conformance to optional

* Add delineator MarkedLocationType

* Add ramp-closure and lane-closure

* Deprecate temporary-traffic-signal MarkedLocationType

* Add markdown docs for TrafficSignal and TrafficSignalMode

* Add TrafficSignal and trafficSignalMode to schema

* Deprecate temporary-traffic-signal MarkedLocationType

* Add traffic-signal FieldDeviceType

* Add references to FieldDeviceType enumerated type

* Add two-way-center-turn-lane and deprecate center-left-turn-lane

* Updating no passing description.

* Updating descriptions of new values.

* Updating undefined wording

* Fixing typo

* Deprecate relationship and add related road event

* Add RelatedRoadEvents object

* Correct related road events object link

* Create RelatedRoadEventType.md

* Add s to related road events property

* Deprecate relationship object

* Update schema with related road events and deprecate relationship

* Update RoadEventFeature.json

* Correct Schema Error

* Update scenario 1 with related road events

also removed relationship that has been deprecated

* Update scenario 1 multipoint with related road events

also removed deprecated relationship

* Update scenario 3 with related road events

also removed deprecated relationship

* Update scenario 4 with related road events

also removed deprecated relationships

* Update scenario 5 with related road events

also removed deprecated relationship

* Corrected scenario 5 errors

* Updating scenario descriptions to describe use of related road events

* Update descriptions and make singular

* Update description of related road events

Also added additional details about deprecated relationship

* Updated descriptions for all enumerations

* Update RelatedRoadEventType to include a link

* Update description of type

* Format all JSON examples

* Add backticks for formatting

* Fix typo

* Fixed typo

* Update description to refer to type of relationship

* Added related road event object and enumeration

Also deprecated relationship

* Updated deprecated note

* Add extra bracket around RelatedRoadEvents for consistency

* Add hyphen to road_event_feed_info description

* Change id to name

Updating the added value in the core details to use the new name field instead of id.

* Update Bridge3 UUID

Updated Bridge3 UUID so it is not duplicated from Bridge2

* Add FieldDeviceCoreDetails to Direction enum Used By

* Expanded Description for Consistency

Expanded the description to refer to it as a field device and link the core details similar to other types of devices (i.e. camera, arrow boards, etc)

* Added TrafficSignal to Oneof Properties

* Added TrafficSignal to the UsedBy

* Modify Description and Example

* Modify example wording

* Capitalization fix for RoadrestrictionFeed

* Removed plural event reference

* Update date verification descriptions

* Add deprecation note to enums in spec content README

* Remove extra periods

* Clean up Scenario 1 wording

* Fix - Use Number not Integer for higher precision, applies to average_speed_kph / volume_vph / occupancy_percent

* Update descriptions

* Remove old object diagram files

* Add new DeviceFeed object diagram

* Add new WorkZoneFeed object diagram

* Update spec-content README to reference new obj diagrams

* Remove references to RoadRestrictionFeed and RestrictionRoadEvent

* Fix RoadEventCoreDetails table

* Remove note from TrafficSensor lane_data property

* Update RelatedRoadEvent.md

* Update object diagram doemR

* remove restriction from EventType enumeration

* Add note below Feeds table on home readme

* Add notes to object/enum pages

* Rename WZDxFeed to WorkZoneFeed

* Add note about previous name of WorkZoneFeed to docs

* Fix typo

* Rename SwzDeviceFeed to DeviceFeed

* Remove backticks when describing the feed (not object)

* Add spaces in feed names

* Clarify feed name with spaces

* Fix reference

* Re-add spaces in feed names

* Use spaces in feed names in examples README

* Use spaces in feed names in examples README

* Update README.md

* Add a bit of content to RELEASES.md

* Remove Swz from Device Feed name

* Update reference to v4.1

* Fix deprecation note reference

* Add release notes for v4.1

* Add release notes to main repo readme

* Update Direction enumeration in new file

* Fix typo in releases

* Remove bridge height example from examples directory

* Fix first/next relationship in examples to use 'sequence"

* Update examples readme

* Add update guide for Work Zone Feed

* Update Creating_a_WZDx_Feed.md

* Add note about WZDx class library to repo README

* Add software libraries section

* Add software libraries to intro paragraph

* Add hyperlink

* Field Device objs on spec-content readme to alphabetical order

* Add used-by to TrafficSignal page

* Remove duplicate WorkZoneRoadEvent link

* Fix grammar in Feed Examples

* Add punctuation

* Cleanup

* Fix dead link to create-feed GitHub guide

* Fix links to TDx repo pages

* Cleanup and add links

* Bold important note about deprecation for 4.1

* Match 4.1 release Refactoring info

* cleanup link in MarkedLocationType

* Update CDS pdf doc link

* Add consider wording

* Change v4.1 release month to August

* Change v4.1 release date to September

* Use hyperlink to TDx

* Update arrow_board_ok_example.geojson

* Update WZDx version in camera example

* Fix TDx link

* Update TDx link to specific object where it is used

* Use backticks for consistency

* Change TDx link to be more specific

* Move used by TDx link to used by section

* Move TDx used by reference to used by section

* Move TDx reference to used by section

* Move TDx reference to used by section

* Move used by TDx reference to used by section

* Remove excess empty lines

* Update TDx reference and remove excess whitespace

* Move TDx reference to used by section

* Move TDx reference to used by section

* Use links for object diagram files

* Add empty line before heading

* Correct name of RelatedRoadEvent and update descriptions in schema

* Update all examples version to 4.1

* Update schema ids and refs to main

* Mark SpatialVerification as deprecated

* Add note about spatial verification deprecated

* Remove important note section

Important note is already included in the data_source_id notes which is more direct and appropriate

* Remove "used by TDx" notes from obj and enum files

Co-authored-by: Jacob Brady <[email protected]>
Co-authored-by: Jacob Brady <[email protected]>
Co-authored-by: Jacob Larson <[email protected]>
Co-authored-by: Skylar Knickerbocker <[email protected]>
Co-authored-by: Dagan Packman <[email protected]>
mark-mockett added a commit that referenced this pull request Dec 13, 2022
@jlarsonOmahaNE @j-d-b
@schnuerle @mark-mockett @sknick-iastate
Add CDS reference (#326)
5f5e912 
* Set up for v4.1 release (#265)

* Add v4.1 schema

* Update current schema version

* Fix schema directory name

* Update documentation to prepare for v4.1

* Update schema IDs

* Fix merge conflicts between main and v4.1 release branch (#272)

* Fix Releases section heading level (#226)

* Fix version in SwzDeviceFeed examples (#240)

* Adding curbs impact

* Adding CDS Reference Object

* Updating link and description

* Fixing typo

* Adding curbs to schema

* Fixing extra whitespace

* Removing extra /

* Adding info for OMF

* Cleanup json

* Adding new object to README

* Update and rename object

* Schema cleanup and renaming of object

* Adding url suffix to conform with current spec

* Updating url name

* Updating zone id naming

* Matching zone id naming to Object

* Updates to CDS references (#342)

* Updating API caps

* Updated curbs_impact object reference/description

* Updated link

* Update property name for CDS curb zones

* Update wording in CdsCurbZoneReference object

* Remove last object description sentence

* Updating CDS Reference Object

* Adding reference to 4.2 schema

* Removing CDS reference from 4.1

* Update impacted_cds_curb_zones

* Delete: Was renamed to WorkZoneFeed

* Delete: Was renamed to DeviceFeed

* Delete: Moved to TDx repo

* Adding impacted_cds_curnb_zones to 4.2 schema

* Remove impacted_cds_curb_zones from 4.1 schema

* Updating text

* Updating text

* Updating cds text

* Updating schema with cds change text

* Fixing CDS object grammar

* Updated impacted curb zone text

* Fix URL reference to CdsCurbZonesReference

* Remove comma and 2nd sentence

* Updating url reference for cds api

* Updating api url data type

* Adding link

* Fixing wrong link

Co-authored-by: Jacob Brady <[email protected]>
Co-authored-by: Jacob Brady <[email protected]>
Co-authored-by: Michael Schnuerle <[email protected]>
Co-authored-by: Mark Mockett <[email protected]>
Co-authored-by: Skylar Knickerbocker <[email protected]>
mark-mockett added a commit that referenced this pull request Feb 9, 2023
@mark-mockett @j-d-b
@jlarsonOmahaNE @sknick-iastate @dxpack @mollybehan
Prepare release/v4.2 for final release (#363)
cdef2a4 
* Deprecate is_moving on ArrowBoard

* Add v4.1 schema

* Update current schema version

* Fix schema directory name

* Update documentation to prepare for v4.1

* Add is_moving to FieldDeviceCoreDetails

* Change TrafficSensorLaneData road_event_id to optional

* Update schema IDs

* Set up for v4.1 release (#265)

* Add v4.1 schema

* Update current schema version

* Fix schema directory name

* Update documentation to prepare for v4.1

* Update schema IDs

* Change TrafficSensorLaneData road_event_id to optional

* Fix SwzDeviceFeed schema

* Fix merge conflicts between main and v4.1 release branch (#272)

* Fix Releases section heading level (#226)

* Fix version in SwzDeviceFeed examples (#240)

* Add road_direction to FieldDeviceCoreDetails

* Use road_direction in SwzDeviceFeed examples

* Add UUID recommendation to FeedDataSource and RoadEventFeature

* Add name property to RoadEventCoreDetails

* Use UUID and name in feed examples

* Use boolean properties for position verification

* Update examples to use boolean position verification properties

* Add deprecation note to SpatialVerification

* Fix property name

* Drop gps from is_startend_position_verified

* Allow feed_info for WZDxFeed

* Add notes to static_sign_text about requirement

* Add personal-device MarkedLocationType

* Deprecate event_status

* Replace start and end accuracy with verified boolean

* Add deprecation note to TimeVerification

* Update deprecation note in EventStatus

* Fix schema conditional requirements

* Complete fix schema conditional requirement

* Fix schema conditional requirement

* Add implementation guidance for completed road events

* Update FieldDeviceCoreDetails update_date description

* Update RoadEventCoreDetails update_date description

* Adding undefined and unknown values

Add undefined and unknown to the direction enumerated types to allow for no road direction and if the producer does not know affected direction of travel.

* Updating descriptions of undefined and unknown

* Adding RoadEventFeature link

* Updating schema to include new values

* Adding the no-passing enumerated type

Per Issue #215

* Adding the new no-passing value to the schema

* Add optional sign_text property to FlashingBeacon

* Change field device road_names conformance to optional

* Add delineator MarkedLocationType

* Add ramp-closure and lane-closure

* Deprecate temporary-traffic-signal MarkedLocationType

* Add markdown docs for TrafficSignal and TrafficSignalMode

* Add TrafficSignal and trafficSignalMode to schema

* Deprecate temporary-traffic-signal MarkedLocationType

* Add traffic-signal FieldDeviceType

* Add references to FieldDeviceType enumerated type

* Add two-way-center-turn-lane and deprecate center-left-turn-lane

* Updating no passing description.

* Updating descriptions of new values.

* Updating undefined wording

* Fixing typo

* Deprecate relationship and add related road event

* Add RelatedRoadEvents object

* Correct related road events object link

* Create RelatedRoadEventType.md

* Add s to related road events property

* Deprecate relationship object

* Update schema with related road events and deprecate relationship

* Update RoadEventFeature.json

* Correct Schema Error

* Update scenario 1 with related road events

also removed relationship that has been deprecated

* Update scenario 1 multipoint with related road events

also removed deprecated relationship

* Update scenario 3 with related road events

also removed deprecated relationship

* Update scenario 4 with related road events

also removed deprecated relationships

* Update scenario 5 with related road events

also removed deprecated relationship

* Corrected scenario 5 errors

* Updating scenario descriptions to describe use of related road events

* Update descriptions and make singular

* Update description of related road events

Also added additional details about deprecated relationship

* Updated descriptions for all enumerations

* Update RelatedRoadEventType to include a link

* Update description of type

* Format all JSON examples

* Add backticks for formatting

* Fix typo

* Fixed typo

* Update description to refer to type of relationship

* Added related road event object and enumeration

Also deprecated relationship

* Updated deprecated note

* Add extra bracket around RelatedRoadEvents for consistency

* Add hyphen to road_event_feed_info description

* Change id to name

Updating the added value in the core details to use the new name field instead of id.

* Update Bridge3 UUID

Updated Bridge3 UUID so it is not duplicated from Bridge2

* Add FieldDeviceCoreDetails to Direction enum Used By

* Expanded Description for Consistency

Expanded the description to refer to it as a field device and link the core details similar to other types of devices (i.e. camera, arrow boards, etc)

* Added TrafficSignal to Oneof Properties

* Added TrafficSignal to the UsedBy

* Modify Description and Example

* Modify example wording

* Capitalization fix for RoadrestrictionFeed

* Removed plural event reference

* Update date verification descriptions

* Add deprecation note to enums in spec content README

* Remove extra periods

* Clean up Scenario 1 wording

* Fix - Use Number not Integer for higher precision, applies to average_speed_kph / volume_vph / occupancy_percent

* Update descriptions

* Remove old object diagram files

* Add new DeviceFeed object diagram

* Add new WorkZoneFeed object diagram

* Update spec-content README to reference new obj diagrams

* Remove references to RoadRestrictionFeed and RestrictionRoadEvent

* Fix RoadEventCoreDetails table

* Remove note from TrafficSensor lane_data property

* Update RelatedRoadEvent.md

* Update object diagram doemR

* remove restriction from EventType enumeration

* Add note below Feeds table on home readme

* Add notes to object/enum pages

* Rename WZDxFeed to WorkZoneFeed

* Add note about previous name of WorkZoneFeed to docs

* Fix typo

* Rename SwzDeviceFeed to DeviceFeed

* Remove backticks when describing the feed (not object)

* Add spaces in feed names

* Clarify feed name with spaces

* Fix reference

* Re-add spaces in feed names

* Use spaces in feed names in examples README

* Use spaces in feed names in examples README

* Adding WZ Example Images

* Update lane numbering and restrictions

* Fix formatting

* Update Examples with images

* Create scenario7_mobileoperation_linestring_example.geojson

* Update boolean values

* Update boolean values scenario 1 multi

* update boolean scenario 2

* update boolean scenario 3

* Update boolean scenario 4

* Update boolean scenario 5

* Add reference to Scenario 7

* Add files via upload

* Update lane closure to match annotated image

* Create scenario6_multi_lane_closure_linestring_example.geojson

* update uuid

* Update scenario 6 and 7 Description

* Update grammar and formatting

* Adding non-example scenario images

* Add text about additional images

* local change to 4.1

* Scenario 1 change to 4.1

* Scenario 1 multi change to 4.1

* Scenario 2  change to 4.1

* Scenario 3 change to 4.1

* Scenario 4  change to 4.1

* Scenario 5  change to 4.1

* Scenario 6  change to 4.1

* Scenario 7  change to 4.1

* Remove Road Restriction Examples

* Update arrow board example to 4.1

* Fix error

* Update camera example to 4.1

* Fix device feed link (#345)

* Fix Work Zone Feed example GeoJSON files (#344)

* Fix boolean values provided as strings in all WorkZoneFeed examples

* Add requirements to TrafficSignal schema (#347)

* Update DeviceFeed schema to fix traffic signal (#360)

* Update DeviceFeed.json (#361)

* Update Reference and add line break

* Remove RoadRestriction Reference

* Remove RoadRestriction Reference

* Remove RoadRestriction Reference

* Remove RoadRestriction Reference

* Remove RoadRestriction Reference

* Remove RoadRestriction Reference

* Remove RoadRestriction Reference

* Remove extra implementation guidance

Appears to have been merged in when updating the branch to latest version

* Docs/validation checklist update (#301)

* Add files via upload

* Delete WZDx_Data_Feed_Self-Validation_Checklist.docx

* Update README.md

* Add files via upload

Updating doc title per Jacob's comment
2 minor updates feedback from Mark

* Delete WZDx_Data_Feed_Self-Validation_Checklist_April22.pdf

Removing old version

* Update README.md

updating file title in hyperlink

* Publish Worker Presence interviews lessons learned document (#362)

* Add WP two-pager to docs readme

* Rename local access example

Rename local access to Scenario 8

* Formatting and remove extra images

Fix formatting issues and remove extra images

* Update Scenario 1 Worker Presence

Updated Scenario 1 to remove 'definition' for road event with false worker presence.  Also update description of scenario 1 work zone to reference worker presence.

* Added Work Zone Type object to examples

Updates Scenario 1 and 7 to include uses of work zone type for active and planned moving operations.  Also update read me to include reference to objects

* Updated annotation on lane shift example

* Edit Scenario 7 second road event text

Co-authored-by: Mark Mockett <[email protected]>

* Update Scenario 7 first road event descrip

Co-authored-by: Mark Mockett <[email protected]>

* Update Scenario 7 Update Date

Co-authored-by: Mark Mockett <[email protected]>

* Update Scenario 7 Feed Update Date

Co-authored-by: Mark Mockett <[email protected]>

* Update scenario 2 description wording

Co-authored-by: Mark Mockett <[email protected]>

* Update remaining example files to v4.2

* Update v4.1 and v4.0 sections of Releases.md to link to respective tags

* Add v4.2 changes to Releases.md using link to tag

* Add v4.2 changes to main readme using relative link

* Move WorkZoneType schema changes from v4.1 to v4.2

* Update schema links to main

* Add update guide for v4.2 about new descriptions.

* Fix TrafficSignal in v4.2 schema

* Update release month to February

* Update example in update guide

* Clarify wording for FlashingBeacon update guide

* Fix link to release section in main readme

* Add WorkZoneType to spec-content readme

* Update WorkZoneFeed object diagram

* unify formatting of object and enum pages

* Fix RelatedRoadEvent header

* Fix spelling mistakes throughout spec

* Update main readme to reflect completion of WZDx development

---------

Co-authored-by: Jacob Brady <[email protected]>
Co-authored-by: Jacob Brady <[email protected]>
Co-authored-by: Jacob Larson <[email protected]>
Co-authored-by: Skylar Knickerbocker <[email protected]>
Co-authored-by: Dagan Packman <[email protected]>
Co-authored-by: Molly Behan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-mockett mark-mockett mark-mockett approved these changes

@mollybehan mollybehan mollybehan approved these changes

@sknick-iastate sknick-iastate Awaiting requested review from sknick-iastate

Assignees
No one assigned
Labels
Non-spec This issue is not related to the specification content Simple This issue is can be easily resolved/implemented Single Approval This non-spec item can be merged after review by a single maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem with SwzFeed examples.
3 participants
@j-d-b @mark-mockett @mollybehan