Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CDS reference #326

Merged
merged 47 commits into from
Dec 13, 2022
Merged

Add CDS reference #326

merged 47 commits into from
Dec 13, 2022

Conversation

jlarsonOmahaNE
Copy link
Collaborator

This Pull request address #241 and will add a Curb Data Spec curb_zone reference for work zones.

@schnuerle
Copy link
Contributor

We've added a similar reference to WZDx from CDS here: openmobilityfoundation/curb-data-specification#96

@j-d-b
Copy link
Collaborator

j-d-b commented Jul 11, 2022

@jlarsonOmahaNE the time frame for changes for v4.1 has closed, so this cannot be implemented for v4.1.

@jlarsonOmahaNE
Copy link
Collaborator Author

@j-d-b Just following Nate's recommendation to open a PR

@natedeshmukhtowery
Copy link
Contributor

I knew we were approaching the end of the v4.1 cycle but assumed that since there are several significant PRs outstanding, this minor addition that had seen a fair amount of discussion as an issue would be fine to include.

@j-d-b
Copy link
Collaborator

j-d-b commented Jul 11, 2022

@jlarsonOmahaNE you can always open a PR at any time! Thank you for doing it. The target branch just shouldn't be release/v4.1 in this case.

@natedeshmukhtowery given that there are no more subgroup meetings, we are past the 4.1 cutoff, and we never discussed the issue (let alone the PR) with the members or subgroup co-chairs, the process for the changes to be implemented was not followed, so I don't think it can be included in this release.

schemas/4.1/RoadEventFeature.json Outdated Show resolved Hide resolved
schemas/4.1/RoadEventFeature.json Outdated Show resolved Hide resolved
spec-content/objects/CDSReference.md Outdated Show resolved Hide resolved
schemas/4.1/RoadEventFeature.json Outdated Show resolved Hide resolved
@jlarsonOmahaNE jlarsonOmahaNE marked this pull request as ready for review October 21, 2022 20:39
Copy link
Collaborator

@mark-mockett mark-mockett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small fixes still needed

schemas/4.2/RoadEventFeature.json Outdated Show resolved Hide resolved
spec-content/README.md Outdated Show resolved Hide resolved
spec-content/objects/CdsCurbZoneReference.md Outdated Show resolved Hide resolved
spec-content/README.md Outdated Show resolved Hide resolved
spec-content/objects/CdsCurbZoneReference.md Outdated Show resolved Hide resolved
spec-content/objects/WorkZoneRoadEvent.md Outdated Show resolved Hide resolved
spec-content/objects/CdsCurbZoneReference.md Outdated Show resolved Hide resolved
spec-content/objects/WorkZoneRoadEvent.md Outdated Show resolved Hide resolved
spec-content/objects/CdsCurbZoneReference.md Outdated Show resolved Hide resolved
spec-content/objects/CdsCurbZoneReference.md Outdated Show resolved Hide resolved
spec-content/objects/CdsCurbZoneReference.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@j-d-b j-d-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes regarding period use for consistency

schemas/4.2/RoadEventFeature.json Outdated Show resolved Hide resolved
schemas/4.2/RoadEventFeature.json Outdated Show resolved Hide resolved
@mark-mockett mark-mockett merged commit 5f5e912 into release/v4.2 Dec 13, 2022
@mark-mockett mark-mockett deleted the feature/cds branch December 13, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Functionality This item relates to adding new functionality to the specification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alignment with OMF's Curb Data Spec
6 participants