Checking Valid AadharCard Number and Some Country Code and Name Validation #1710
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1710 +/- ##
===========================================
- Coverage 100.00% 99.80% -0.20%
===========================================
Files 101 101
Lines 2005 2016 +11
Branches 452 455 +3
===========================================
+ Hits 2005 2012 +7
- Misses 0 2 +2
- Partials 0 2 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Thank you for your contribution @pnirmale
Some comments regarding your PR:
- Since Aadhar is an IdentityNumber, i suggest you add the Aadhar validation to
isIdentityCard - Your
isCountryByCodeis not a validator, the purpose of this library is to provide a list of string validators and sanitizers client-sidetests are meant to test if the minified version of validator is working correctly, you should probably check test examples fromtest/validatorsand add valid/invalid cases- Some lines are not covered, please check coverage report
- Add an entry in
README.mdfor the added validators
Also a suggestion, you should probably open a PR about a single new validator at a time to prevent long review and approval time. Personally i don't agree with adding a isValidCountryName validator
.github/pull_request_template.md
Outdated
| @@ -6,6 +6,18 @@ feat(validatorName): brief title of what has been done | |||
| <!--- briefly describe what you have done in this PR ---> | |||
|
|
|||
| ## Checklist | |||
| Validator added: | |||
There was a problem hiding this comment.
Can you discard your changes to this file?
I suppose you made a copy/paste error
There was a problem hiding this comment.
Thanks for your help. I'm not sure what it is exactly you'd like me to delete, could you please point i
There was a problem hiding this comment.
Point it out, obviously I have no clue what I'm doing or how I wound up here. Sorry about that
There was a problem hiding this comment.
Yes Surely I do required changes
There was a problem hiding this comment.
What is your opinion about isCountryByCode i could change to isvalidCountryCode ?
My opinion about isValidCountryName= it will beneficial when we are not providing those search country option
Validator added:
1)isAadharCardNumber=basically Aadhar card number is unique identitiy number of Indian citizen and it require in various form filing along with documents .It is 12 or 16 digit number so i check for both using regex
2)isCountryByCode= Each country has it own Country Code Like US ,IN ,AF so we check give Country Code and find it valid or not along with is return country name if is is invalid it return invalid country code
3)isValidCountryName=if we are only using country name the we need to valid country name also so I list down all the country an validating country from all country list currently available
No Readme Updated
All the test case are return in Client-side.js and passed
