Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AadharCard Validation added in isIdentityCard on the basis of previous #1710 #1713

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

pnirmale
Copy link

Validator added:
1)AadharCardNumber=basically Aadhar card number is unique identitiy number of Indian citizen and it require in various form filing along with documents .It is 12 or 16 digit number so i check for both using regex
On the basis of suggestion i made required changes and added it into the isIdentityCard and tests are added to it

Previous Pull request
#1710
Screenshot 2021-08-20 at 10 32 57 PM

@pnirmale pnirmale changed the title Prathamesh AadharCard Validation added in isIdentityCard on the basis of previous #1710 Aug 20, 2021
@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #1713 (7545306) into master (8c4b3b3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1713   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          101       101           
  Lines         2005      2016   +11     
  Branches       452       455    +3     
=========================================
+ Hits          2005      2016   +11     
Impacted Files Coverage Δ
src/index.js 100.00% <ø> (ø)
src/lib/isIdentityCard.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c4b3b3...7545306. Read the comment docs.

Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that there is already an implementation of Aadhar in validator.js . What is the difference between your implementation and existing IN locale added here #1322

@pnirmale
Copy link
Author

Yes there is change it look for only 12 digit Aadhar number and but my code is for both 12 and 16 (VID number that is present on the Aadhar card) digit and #1322 is also valid but only in case of 12 digit but some form require you both details no & vid in that case my code will be great and helpful

@pnirmale
Copy link
Author

I think it is better to validate with the help of the card name instead of the country identity and suppose some one ask you to validate card and eg aadhar(instead of number if you put vid then it shows false )

@03-65
Copy link

03-65 commented Sep 9, 2021

How do I push this

@03-65
Copy link

03-65 commented Sep 9, 2021

Merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants