-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AadharCard Validation added in isIdentityCard on the basis of previous #1710 #1713
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1713 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 101 101
Lines 2005 2016 +11
Branches 452 455 +3
=========================================
+ Hits 2005 2016 +11
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized that there is already an implementation of Aadhar in validator.js
. What is the difference between your implementation and existing IN
locale added here #1322
Yes there is change it look for only 12 digit Aadhar number and but my code is for both 12 and 16 (VID number that is present on the Aadhar card) digit and #1322 is also valid but only in case of 12 digit but some form require you both details no & vid in that case my code will be great and helpful |
I think it is better to validate with the help of the card name instead of the country identity and suppose some one ask you to validate card and eg aadhar(instead of number if you put vid then it shows false ) |
How do I push this |
Merge |
Validator added:
1)AadharCardNumber=basically Aadhar card number is unique identitiy number of Indian citizen and it require in various form filing along with documents .It is 12 or 16 digit number so i check for both using regex
On the basis of suggestion i made required changes and added it into the isIdentityCard and tests are added to it
Previous Pull request
#1710