fix(cache): set content length for put artifact #9183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
NicholasLYang
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9177
In #8081 we changed from setting the body of our
PUTrequests from a vec of bytes to a stream of bytes.This results in the underlying
hyperrequest having a body withKind::Wrappedinstead ofKind::Once. This results in the body no longer having an exact length. With the body no longer having an exact length,hyperwould no longer setContent-Lengthfor us source.This PR explicitly sets the content length header. It would be nice if we could set the length on the body itself, but
hyperdoesn't allow for this flexibility. (We cannot simply implement a size hint onUploadProgress, but the size hint should return the size of the stream, not the number of bytes in the stream)Testing Instructions
Added an assertion on the mock
PUT /artifactsendpoint to make sure thatContent-Lengthgets set.