Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support '?' for RPC errors. #199

Closed
Harshit933 opened this issue Mar 22, 2024 · 1 comment · Fixed by #259
Closed

Support '?' for RPC errors. #199

Harshit933 opened this issue Mar 22, 2024 · 1 comment · Fixed by #259
Assignees
@vincenzopalazzo
Labels
🦀 - rust Rust related things P-hight Hiight Priotity issue
Milestone
v24.06

Comments

@Harshit933
Copy link
Collaborator

For now each time .map_err(|err| {}) looks odd.
@Harshit933 Harshit933 added the 🦀 - rust Rust related things label Mar 22, 2024
@vincenzopalazzo vincenzopalazzo added this to the v24.03 milestone Mar 23, 2024
@vincenzopalazzo vincenzopalazzo moved this to Backlog in lampo v24.03 Mar 23, 2024
@vincenzopalazzo vincenzopalazzo modified the milestones: v24.03, v24.06 Mar 30, 2024
@vincenzopalazzo vincenzopalazzo self-assigned this Mar 30, 2024
@vincenzopalazzo vincenzopalazzo moved this to Todo in v24.06 Mar 30, 2024
@vincenzopalazzo vincenzopalazzo added the P-low Low priority issue label May 30, 2024
@vincenzopalazzo vincenzopalazzo added P-hight Hiight Priotity issue and removed P-low Low priority issue labels Jun 17, 2024
@vincenzopalazzo
Copy link
Owner

I should improve this shit, for this release!

Assign to my self

vincenzopalazzo added a commit that referenced this issue Jun 19, 2024
@vincenzopalazzo
core: improve error handling with anyhow
309d728 
This is a fix step on improving the error handling, but
we still need to find out how to improve the error handling
for external error type. Probably a good solution for this
is thierror.

Suggested-by: @Harshit933
Link: #199
Signed-off-by: Vincenzo Palazzo <[email protected]>
@vincenzopalazzo vincenzopalazzo mentioned this issue Jun 19, 2024
Merged
vincenzopalazzo added a commit that referenced this issue Jun 19, 2024
@vincenzopalazzo
core: improve error handling with anyhow
7f8da1d 
This is a fix step on improving the error handling, but
we still need to find out how to improve the error handling
for external error type. Probably a good solution for this
is thierror.

Suggested-by: @Harshit933
Link: #199
Signed-off-by: Vincenzo Palazzo <[email protected]>
@github-project-automation github-project-automation bot moved this from Todo to Done in v24.06 Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vincenzopalazzo vincenzopalazzo

Labels
🦀 - rust Rust related things P-hight Hiight Priotity issue
Projects
No open projects
v24.06
Status: Done
Milestone
v24.06
Development

Successfully merging a pull request may close this issue.

core: improve error handling with anyhow vincenzopalazzo/lampo.rs
2 participants
@vincenzopalazzo @Harshit933