core: improve error handling with anyhow #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fix step on improving the error handling, but we still need to find out how to improve the error handling for external error type. Probably a good solution for this is thierror. Suggested-by: @Harshit933 Link: #199 Signed-off-by: Vincenzo Palazzo <[email protected]>
This allow to find the problem at compile time, and also to unify the way of writing rust. Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo
force-pushed
the
macros/error-handling
branch
from
07d943c to
ac09a6f
Compare
Harshit933
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix step on improving the error handling, but we still need to find out how to improve the error handling for external error type. Probably a good solution for this is thierror.
Suggested-by: @Harshit933
Fixes #199