-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add partial support for ipset #387
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great contribution!
Only minor documentation nits.
"golang.org/x/sys/unix" | ||
) | ||
|
||
type IPSetEntry struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exported name without docstring.
Please add docstrings to all names which are started with upper case, using convention described in https://blog.golang.org/godoc-documenting-go-code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
f56c1f0
to
bb40bd5
Compare
This is looking good. Can you please squash it down into a single commit? |
f8761a6
to
0df1233
Compare
These are netlink responses. They are required by |
bbde686
to
f0450b3
Compare
hi @corny I have a problem with this patch
any idea why? |
7b3d101
to
e15c8f8
Compare
@onokonem You don't have the proper header files on your system. |
@vishvananda ping |
@corny Thanks for updating this. Our policy is for prs to be a single commit. Can you squash this down? You can add a co-authored-by line for the original author so we don't lose their contributions. |
I squashed it |
Looking forward to read your comments and improve my code.