Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial IPSet support #408

Closed
wants to merge 53 commits into from
Closed

Conversation

onokonem
Copy link

@onokonem onokonem commented Dec 5, 2018

No description provided.

@aboch
Copy link
Collaborator

aboch commented Dec 11, 2018

@onokonem, given #387 was already there, can you please sync with @corny to avoid duplicate code proposal. (I have not looked at the two PR in detail yet, if there is no overlap then we are good)

@onokonem
Copy link
Author

Ok will do. for the reason I do not fully understand I did not realise this functionality is already there.

@aboch
Copy link
Collaborator

aboch commented Jun 19, 2019

@onokonem @corny
Regarding the ipset support where we are ending up with the duplicated proposals issue.
I discussed with @vishvananda and @fcrisciani: We are proposing the following transitions:

  1. @onokonem leads the transition changes (based on his continuous activity on this area)
  2. @onokonem rearranges his initial ipset support PR (initial IPSet support #408) changes to be incremental work on top of @corny 's commits (based on @corny's PR came in first).
  3. @onokonem retains @corny's authored commit (the squash of his 7 commits from Add partial support for ipset #387) in the new PR.
  4. The new PR must have two commits: One from @corny and one from @onokonem
  5. close Add partial support for ipset #387 and initial IPSet support #408 when above is done

Thank you.

paravmellanox and others added 4 commits September 7, 2019 01:38
RDMA subsystem can be running in shared or exclusive mode with regards
to sharing RDMA device sharing among multiple network namespaces.

Add and API to query such mode of kernel similar to iproute2 command
$ rdma system show netns

Signed-off-by: Parav Pandit <[email protected]>
Add an API to change the RDMA subsystem network namespace mode as either
shared or exclusive similar to

$ rdma system set netns { shared | exclusive }

Signed-off-by: Parav Pandit <[email protected]>
This deserializes the tx queue, and rx queue count on link
deserialization. We already supported it on serialization.

Signed-off-by: Sargun Dhillon <[email protected]>
Farid Zakaria and others added 14 commits September 7, 2019 01:38
In order to support BPF_SYSCALL `PROG_GET_FD_BY_ID` -- the ID of the
eBPF must be available.

Add the additional enumerations and handle them when parsing the BPF
filter.
This change adds support for setting VLAN QoS (priority) field for the
SR-IOV Virtual Function links.
iproute2's own netlink library asserts that the sockaddr sender pid
has to be the one of the kernel [0]. It also doesn't bail out on pid
mismatch but only skips the message instead. We've seen cases where
the latter had a pid 0; in such case we should skip to the next nl
message instead of hard bail out.

  [0] https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/tree/lib/libnetlink.c
      rtnl_dump_filter_l(), __rtnl_talk_iov()

Signed-off-by: Daniel Borkmann <[email protected]>
Signed-off-by: bingshen.wbs <[email protected]>
Today netlink package supports Get/Set of a VF's max TX rate
via IFLA_VF_TX_RATE netlink attribute.

This patch add support to Get/Set of a VFs min and max TX rate
via IFLA_VF_RATE netlink attribute.

- Add support to set min/max tx rate for VF via IFLA_VF_RATE
- Added IFLA_VF_RATE min/max tx rate attributes to netlink.VfInfo
  including parsing support in netlink.parseVfInfo()

NOTE: According to [1] IFLA_VF_RATE takes precedence over
      IFLA_VF_TX_RATE. Dealing with the co-existance of these
      netlink attributes is left for the user to handle.

[1]https://lists.openwall.net/netdev/2014/05/22/42
AddrReplace was missing, could not compile on OSX
- Add a new Link type, IPoIB, that exposes the following IPoIB attributes:
    * IFLA_IPOIB_PKEY
    * IFLA_IPOIB_MODE
    * IFLA_IPOIB_UMCAST
- Suppport Deserialize for IPoIB link attributes in LinkDeserialize()
- Support IPoIB attributes in LinkAdd()
- replace following values to unix.*
  AF_MPLS, RTA_NEWDST, RTA_ENCAP_TYPE, RTA_ENCAP
When subscribing to neigh updates, the updates for all neigh
protocol families are received. However when listExisting is set,
the request is made with AF_UNSPEC family, this request does not
include AF_BRIDGE entries.

This patch add a second request for AF_BRIDGE entries.

Add test for existing AF_BRIDGE entry and make expectNeighUpdate
take a slice of expected updates

Creates a VXLAN interface for this test as its AF_BRIDGE entries
looks a lot like usual ones

Also add support for latest (2014+) neighbour attributes

NDA_MASTER was added back in 2014, it indicates whether a neigh
entry is linked to a master interface and index of this interface.

The other entries, namely NDA_LINK_NETNSID and NDA_SRC_VNI were
added later and will need extra handling.

Signed-off-by: Nicolas Belouin <[email protected]>
@jellonek
Copy link
Contributor

jellonek commented Nov 7, 2019

Can you rebase that on top of current master?

@jellonek
Copy link
Contributor

jellonek commented Nov 7, 2019

Ups. This one has to be closed...

@onokonem
Copy link
Author

onokonem commented Nov 7, 2019

of course I can rebase this on top of current master

we are using this functionality so we would be happy to get this merged to the upstream

@onokonem
Copy link
Author

onokonem commented Nov 7, 2019

@onokonem @corny
Regarding the ipset support where we are ending up with the duplicated proposals issue.
I discussed with @vishvananda and @fcrisciani: We are proposing the following transitions:

1. @onokonem leads the transition changes (based on his continuous activity on this area)

2. @onokonem rearranges his initial ipset support PR (#408) changes to be incremental work on top of @corny 's commits  (based on @corny's PR came in first).

3. @onokonem retains @corny's authored commit (the squash of his 7 commits from #387) in the new PR.

4. The new PR must have two commits: One from @corny and one from @onokonem

5. close #387 and #408 when above is done

Thank you.

for the reason I do not fully understand I did not saw this comment before

yes this sounds like a plan

I'm working on some addition to the ipset support right now on our side so I'll take the steps proposed as part of this activity.

onokonem and others added 9 commits November 11, 2019 17:09
Signed-off-by: Tobias Klauser <[email protected]>
RDMA subsystem can be running in shared or exclusive mode with regards
to sharing RDMA device sharing among multiple network namespaces.

Add and API to query such mode of kernel similar to iproute2 command
$ rdma system show netns

Signed-off-by: Parav Pandit <[email protected]>
Add an API to change the RDMA subsystem network namespace mode as either
shared or exclusive similar to

$ rdma system set netns { shared | exclusive }

Signed-off-by: Parav Pandit <[email protected]>
Add an API to change net namespace of RDMA device similar to

$ rdma dev set [DEV] netns NSNAME

Signed-off-by: Parav Pandit <[email protected]>
iproute2's own netlink library asserts that the sockaddr sender pid
has to be the one of the kernel [0]. It also doesn't bail out on pid
mismatch but only skips the message instead. We've seen cases where
the latter had a pid 0; in such case we should skip to the next nl
message instead of hard bail out.

  [0] https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/tree/lib/libnetlink.c
      rtnl_dump_filter_l(), __rtnl_talk_iov()

Signed-off-by: Daniel Borkmann <[email protected]>
Today netlink package supports Get/Set of a VF's max TX rate
via IFLA_VF_TX_RATE netlink attribute.

This patch add support to Get/Set of a VFs min and max TX rate
via IFLA_VF_RATE netlink attribute.

- Add support to set min/max tx rate for VF via IFLA_VF_RATE
- Added IFLA_VF_RATE min/max tx rate attributes to netlink.VfInfo
  including parsing support in netlink.parseVfInfo()

NOTE: According to [1] IFLA_VF_RATE takes precedence over
      IFLA_VF_TX_RATE. Dealing with the co-existance of these
      netlink attributes is left for the user to handle.

[1]https://lists.openwall.net/netdev/2014/05/22/42
- Add a new Link type, IPoIB, that exposes the following IPoIB attributes:
    * IFLA_IPOIB_PKEY
    * IFLA_IPOIB_MODE
    * IFLA_IPOIB_UMCAST
- Suppport Deserialize for IPoIB link attributes in LinkDeserialize()
- Support IPoIB attributes in LinkAdd()
@jellonek
Copy link
Contributor

Tests show that rebase was probably not successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.