Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs Example: change to use display: none; to hide panels #1197

Closed
ZoeBijl opened this issue Oct 7, 2019 · 0 comments · Fixed by #1198
Closed

Tabs Example: change to use display: none; to hide panels #1197

ZoeBijl opened this issue Oct 7, 2019 · 0 comments · Fixed by #1198
Assignees
@ZoeBijl
Labels
bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern
Milestone
1.2 Release 1

Comments

@ZoeBijl
Copy link
Contributor

ZoeBijl commented Oct 7, 2019 •
edited
Loading

Given the discussion in this HTML spec issue we should change the example to use display: none instead of the hidden-attribute to conform with the HTML spec.

We can clarify/edit the example again if the HTML issue’s resolution requires that.
@ZoeBijl ZoeBijl added bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern labels Oct 7, 2019
@ZoeBijl ZoeBijl self-assigned this Oct 7, 2019
ZoeBijl added a commit that referenced this issue Oct 7, 2019
@ZoeBijl
Tabs Example: use display: none; to hide panels (Issue #1197)
74b84db
@ZoeBijl ZoeBijl mentioned this issue Oct 7, 2019
Merged
@ZoeBijl ZoeBijl added this to the 1.2 Release 1 milestone Oct 7, 2019
@mcking65 mcking65 mentioned this issue Aug 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZoeBijl ZoeBijl

Labels
bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern
Projects
Tabs Pattern and Examples Development Project
Status: Complete
Milestone
1.2 Release 1
Development

Successfully merging a pull request may close this issue.

Tabs Example: use display: none; to hide panels (Issue #1197) w3c/aria-practices
1 participant
@ZoeBijl