Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs Example: use display: none; to hide panels (Issue #1197) #1198

Merged
merged 1 commit into from
Oct 7, 2019
Merged

Tabs Example: use display: none; to hide panels (Issue #1197) #1198

merged 1 commit into from
Oct 7, 2019

Conversation

ZoeBijl
Copy link
Contributor

@ZoeBijl ZoeBijl commented Oct 7, 2019

Closes #1197

@ZoeBijl ZoeBijl requested review from smhigley and mcking65 October 7, 2019 08:38
@ZoeBijl ZoeBijl mentioned this pull request Oct 7, 2019
Open
smhigley
smhigley approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@smhigley smhigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disagreement with WHATWG wording aside, this looks good :)

@ZoeBijl ZoeBijl merged commit 39a79fc into master Oct 7, 2019
michael-n-cooper pushed a commit that referenced this pull request Oct 7, 2019
Generated by TRAVIS-CI 39a79fc
7cfd242 
Tabs Example: use display: none; to hide panels (pull #1198)
@ZoeBijl ZoeBijl deleted the issue1197-tab-panel-hiding branch October 7, 2019 22:18
@mcking65 mcking65 mentioned this pull request Aug 2, 2022
Closed
@Clemens-git76 Clemens-git76 mentioned this pull request Apr 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smhigley smhigley smhigley approved these changes

@mcking65 mcking65 Awaiting requested review from mcking65

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tabs Example: change to use display: none; to hide panels
2 participants
@ZoeBijl @smhigley