Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infrastructure: Fix inconsistencies in lists of CSS and JS files on 3 example pages (Related to wai-aria-practices issue 255) #2883

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

alflennik
Copy link
Contributor

@alflennik alflennik commented Dec 12, 2023

This is a minor enhancement related to the PR w3c/wai-aria-practices#281 over in wai-aria-practices, which fixes issue w3c/wai-aria-practices#255.

That PR addresses inaccuracies with the last modified date listed in the footer of example pages. However I noticed a few examples that did not follow the common convention CSS and JS files are listed. This PR fixes the inconsistencies.

This PR can be reviewed independently from the other PR, and can be merged when ready, before or after 281 is reviewed and merged.


WAI Preview Link (Last built on Tue, 12 Dec 2023 18:23:15 GMT).

Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for this fix @alflennik!

@mcking65 mcking65 changed the title Fix Some Inconsistencies in Example CSS JS File Lists (Related to #255) Infrastructure: Fix inconsistencies in lists of CSS and JS files on 3 example pages (Related to wai-aria-practices issue 255) Dec 12, 2023
@mcking65 mcking65 added Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation Build Process Related to build process automation, including build scripts, linting, syntax automated tests, etc. labels Dec 12, 2023
@mcking65 mcking65 merged commit b2cae7f into main Dec 12, 2023
19 checks passed
@mcking65 mcking65 deleted the consistent-file-list branch December 12, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Process Related to build process automation, including build scripts, linting, syntax automated tests, etc. Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants