-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix last modified date issue #281
Conversation
✅ Deploy Preview for aria-practices ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@alflennik This is a partial fix, and it is a good step forward. However, waht we'd ultimately like is quite a bit more complicated. The last changed date should be the date of last change for any of the HTML, CSS, or JS that are specific to the example. We only want to consider the files specific to the example, not any of the shared CSS or JS. For example, for the select-only combox example, we would want to show the date of most recent change for any of the following files in the
|
Fantastic, thank you @alflennik. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alflennik looks good to me! I tested against an updated version of w3c/aria-practices
locally, and I did also see the dates update where expected.
return date; | ||
}; | ||
|
||
const dependencyFilePaths = html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clever!
The example pages include the date that the example last changed, which is sourced from the git history. However in CI builds of the site, the last modified date ends up being the date the build was last done.
The cause seems to be that GitHub Actions uses a shallow clone instead of a full clone with the complete history.
We won't know for sure if this is solution until we merge this PR to main and the offending action runs.
See #255.